add limitation on number of captures in DQT #13735
Conversation
| @@ -1008,7 +1047,9 @@ namespace rs2 | |||
| _plane_fit(false), | |||
| _roi_percentage(0.4f), | |||
| _active(true), | |||
| _recorder(viewer_model) | |||
| _recorder(viewer_model), | |||
| _limit_captures(0), | |||
There was a problem hiding this comment.
At another place we set this default to 1
Maybe we want to combine to a single member that has
-1 / 0 = don't limit
= 1 = limit
?
There was a problem hiding this comment.
one member belongs to the tool model class. if I'll set it to default 0, then the value which will be displayed on the edit box once the user clicks the check box, will be zero, and we don't want to allow to limit to zero.
the other member belongs to the metrics_model. as a default value we want to set it to a value that must be changed if the limitation was asked (zero is a good candidate). i can change it to 1 if you want and it will still work, but i think it is better to leave it as zero.
we must have 2 separate members, one for each class.
| { | ||
| _limit_captures = limit_captures; | ||
| _is_capture_limited = limit_captures >= 0; |
There was a problem hiding this comment.
This is was we may want a single member?
There was a problem hiding this comment.
we must have a member for each class. the tool_model for display of the default value (1), and the metric_model for the logic. the limit_capture in metric_model act also as a counter which is been decreased on each capture ==> this is another reason why we must have two separate members - we don't want to UI to be decreased on each frame captured.
tracked by RSDSO-20044