-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support D430 gmsl #13740
base: development
Are you sure you want to change the base?
support D430 gmsl #13740
Conversation
…into d430-gmsl
src/ds/d400/d400-private.h
Outdated
@@ -39,6 +39,7 @@ namespace librealsense | |||
const uint16_t RS455_PID = 0x0B5C; // D455 | |||
const uint16_t RS457_PID = 0xabcd; // D457 | |||
const uint16_t RS457_RECOVERY_PID = 0xbbcd; // D457 DFU Recovery | |||
const uint16_t RS430_GMSL_PID = 0xabce; // D450 GMSL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we do reuse the same recovery PID as D457, let's rename it
Currently it's RS457_RECOVERY_PID
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will look into if it's necessary to have separate recovery pid.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this still open?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated to RS400_MIPI_RECOVERY_PID
Dont we need udev rules update for D437? Some kind of patches? |
driver not changed and same video nodes as d457, so no change in udev rules is required. |
Improved depth node detection logic to search first the video node links then if that's not available search the format on actual video nodes. Performance is about same but slightly better because majority of the latency is in reading the gvd. |
Error: src/linux/backend-v4l2.cpp has tabs |
Fixed, tabs removed. |
changes:
support D430 GMSL