Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support D430 gmsl #13740

Open
wants to merge 22 commits into
base: development
Choose a base branch
from
Open

Conversation

gwen2018
Copy link
Contributor

@gwen2018 gwen2018 commented Feb 4, 2025

changes:
support D430 GMSL

common/fw-update-helper.cpp Outdated Show resolved Hide resolved
include/librealsense2/rs.h Outdated Show resolved Hide resolved
src/ds/d400/d400-factory.cpp Outdated Show resolved Hide resolved
src/ds/d400/d400-factory.cpp Outdated Show resolved Hide resolved
src/ds/d400/d400-factory.cpp Outdated Show resolved Hide resolved
@@ -39,6 +39,7 @@ namespace librealsense
const uint16_t RS455_PID = 0x0B5C; // D455
const uint16_t RS457_PID = 0xabcd; // D457
const uint16_t RS457_RECOVERY_PID = 0xbbcd; // D457 DFU Recovery
const uint16_t RS430_GMSL_PID = 0xabce; // D450 GMSL
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we do reuse the same recovery PID as D457, let's rename it
Currently it's RS457_RECOVERY_PID

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will look into if it's necessary to have separate recovery pid.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this still open?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to RS400_MIPI_RECOVERY_PID

src/ds/d400/d400-private.h Outdated Show resolved Hide resolved
src/linux/backend-v4l2.cpp Outdated Show resolved Hide resolved
@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 4, 2025

Dont we need udev rules update for D437? Some kind of patches?

@gwen2018
Copy link
Contributor Author

gwen2018 commented Feb 5, 2025

driver not changed and same video nodes as d457, so no change in udev rules is required.

@gwen2018
Copy link
Contributor Author

gwen2018 commented Feb 6, 2025

Improved depth node detection logic to search first the video node links then if that's not available search the format on actual video nodes. Performance is about same but slightly better because majority of the latency is in reading the gvd.

@Nir-Az
Copy link
Collaborator

Nir-Az commented Feb 6, 2025

Error: src/linux/backend-v4l2.cpp has tabs

@gwen2018
Copy link
Contributor Author

gwen2018 commented Feb 8, 2025

Fixed, tabs removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants