bug: 지원자의 프로토콜이 붙지 않은 포트폴리오 링크에 대한 버그 수정 #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2yunseong
approved these changes
Sep 19, 2024
geongyu09
approved these changes
Sep 21, 2024
| <Link | ||
| href={url} | ||
| target="_blank" | ||
| rel="noopener noreferrer" |
There was a problem hiding this comment.
noopener noreferrer를 처음 알았네요..!
이런 디테일도 좋아보입니다
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
주요 변경사항
리뷰어에게...
프로토콜이 붙지 않은 url에 대해서 http 프로토콜을 붙이도록 함수를 구현했는데 https에 대한 처리는 어떻게 해야할 지 모르겠네요. (https로 접근을 해야하는 사이트인데 http로 접근하면 문제가 발생할 수도 있을 것 같습니다.)
관련 이슈
closes #223