Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement an antimeridian cutting fix ported from the python package #282

Open
wants to merge 7 commits into
base: as/algorithms
Choose a base branch
from

Conversation

asinghvi17
Copy link
Member

@asinghvi17 asinghvi17 commented Mar 18, 2025

Implement an antimeridian cutting fix ported from the python package. This is an interesting fix, since it doesn't fit in the top down framework of fixes so far. It needs special handling for e.g. multipolygons in place of polygons, and multilinestrings in place of linestrings. But we don't have that mechanism at all in fix, so it probably needs to be added at some point...

Fix #218

Copy link
Member Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@asinghvi17 asinghvi17 mentioned this pull request Mar 18, 2025
@asinghvi17 asinghvi17 marked this pull request as ready for review March 18, 2025 20:59
enables geoms .|> fix

since fix doesnt have apply integrated(!) we should fix
this is worse for performance, better for predictability and correctness (the most complex trait will be chosen for the application rather than the least complex)
@asinghvi17
Copy link
Member Author

Looks like the issue here is that fix now does antimeridian cutting on planar polygons, where it shouldn't be done. Can remove it for now.

A nice API is fix(corrections...) = x -> fix(x; corrections) that I should add and test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant