Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MLX] Updated to v0.22.1 #10374

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

stemann
Copy link
Contributor

@stemann stemann commented Jan 30, 2025

No description provided.

@ararslan
Copy link
Member

ararslan commented Feb 4, 2025

It looks like the FreeBSD compilers are still 13.2:

[02:18:53] -- Check for working C compiler: /opt/bin/x86_64-unknown-freebsd13.2-libgfortran5-cxx11/x86_64-unknown-freebsd13.2-clang - skipped

That would likely explain why the same error is still occurring.

@giordano
Copy link
Member

giordano commented Feb 4, 2025

The paths don't magically change, they come from BinaryBuilderBase.jl which believes we use 13.2, it doesn't know what's going on inside the recipe.

@stemann
Copy link
Contributor Author

stemann commented Feb 4, 2025

Just checked as well, the error that is left now is not the "C++-17 on FreeBSD 13.2 issue", cf. #10402, but just the one being addressed in ml-explore/mlx#1823 .

@stemann stemann changed the title [MLX] Updated to "master" [MLX] Updated to v0.22.1 Feb 7, 2025
@stemann stemann marked this pull request as ready for review February 7, 2025 16:57
@stemann stemann force-pushed the feature/mlx_next-2025-02 branch from 83bd51f to f9e49ca Compare February 7, 2025 16:57
Updated FreeBSD SDK to 13.4, and 14.1, for better C++-17 support. To solve `error: constexpr variable cannot have non-literal type 'const std::array<uint32_t, 8>' (aka 'const array<unsigned int, 8>')`
@stemann stemann force-pushed the feature/mlx_next-2025-02 branch from f9e49ca to 8390070 Compare February 7, 2025 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants