-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated FreeBSD from 13.2 to 13.4 / 14.1 #10402
base: master
Are you sure you want to change the base?
Conversation
I think @ararslan has opinions here, probably wanted to jump to FreeBSD 14 altogether. |
f32ab64
to
bcec3ce
Compare
Since FreeBSD 13 is still supported upstream, it'd be ideal if we could continue to build on 13 since binaries are forward but not backward compatible across FreeBSD versions. (The apparent exception to this is 13.2 on AArch64, as binaries built there seem not to work entirely as expected on 14+). It'd be unfortunate to completely drop support for anybody running 13 locally. If 13.4 fixes the issue then that seems like a good choice to me. I'll need to try a 13.4 VM on AArch64 to see whether that fixes the issue we observed with MPFR not being forward compatible; we may need to go right to 14 (perhaps 14.1) on AArch64. IMO it's okay, albeit not entirely ideal, to have different system requirements on x86-64 and AArch64. |
That's what we do already on linux, we have different glibc versions for different architectures |
Okay cool, let's try 13.4 on x86-64 and 14.1 on AArch64 then. |
Co-authored-by: Alex Arslan <[email protected]>
The next question is "who's going to rebuild 22 different versions of GCC and hope nothing breaks because otherwise they'll have to deal with that?" 😉 |
I'm just giving FreeBSD 14.1 a spin in #10374 to see if the C++ issue is still fixed. |
#10374 is happy with FreeBSD 14.1 as well :-) |
Enables better C++-17 support.
E.g. for MLX, which ran into
error: constexpr variable cannot have non-literal type 'const std::array<uint32_t, 8>' (aka 'const array<unsigned int, 8>')
with the FreeBSD 13.2 libc++ SDK in #10374 - which could be remedied by using FreeBSD 13.4 instead of 13.2: cea8b97How to use another FreeBSD SDK for a CMake-based build: