avoid overwriting methods in CompositeOp tests #147
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes function name conflicts in CompositeOp tests by renaming duplicate function definitions to avoid overwriting methods during test execution.
- Renamed duplicate
c!functions toc1!andc2!to prevent conflicts - Renamed duplicate
J!functions toJ1!andJ2!to prevent conflicts - Updated corresponding function calls to use the new names
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
|
The remaining failures are those of #145. |
arnavk23
added a commit
to arnavk23/ShiftedProximalOperators.jl
that referenced
this pull request
Oct 19, 2025
…by renaming c!/J! to c_allocs!/J_allocs! in allocs tests to avoid method overwrites
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #146