Specialize functions to avoid dynamic dispatch #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This helps reduce allocations and make client requests a little more stable with regards to allocations and performance.
quinnj
added a commit
to JuliaWeb/OpenSSL.jl
that referenced
this pull request
Jan 7, 2023
Together with JuliaWeb/HTTP.jl#985, this reduces allocations on a typical request by about ~100. The main wins here are hard-coding TCPSocket as the `io` field of `SSLStream` (which we assume anyway), and changing the `geterror` function to a macro to avoid the closure boxing problem.
Codecov Report
@@ Coverage Diff @@
## master #985 +/- ##
=======================================
Coverage 82.61% 82.61%
=======================================
Files 36 36
Lines 3037 3037
=======================================
Hits 2509 2509
Misses 528 528
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
quinnj
added a commit
to JuliaWeb/OpenSSL.jl
that referenced
this pull request
Jan 7, 2023
* Refactor code a bit to reduce allocations and dynamic dispatches Together with JuliaWeb/HTTP.jl#985, this reduces allocations on a typical request by about ~100. The main wins here are hard-coding TCPSocket as the `io` field of `SSLStream` (which we assume anyway), and changing the `geterror` function to a macro to avoid the closure boxing problem. * Run HTTP.jl tests on changes in OpenSSL * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This helps reduce allocations and make client requests a little more stable with regards to allocations and performance.