issue#82 게시글 리팩토링 #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
9 tasks
Dobbymin
reviewed
Jan 10, 2025
Comment on lines
+35
to
+38
|
|
||
| # api docs | ||
| /src/models |
There was a problem hiding this comment.
해당 파일들에 eslint 관련 disable 속성이 많이 적용되어있는것 같은데, eslintignore 파일도 생성해서 무시 파일에 추가하는건 어떨까요?
There was a problem hiding this comment.
해당 파일은 저희가 직접 작성하는 게 아니라, 라이브러리에서 작성해주는 파일이니까 따로 eslintignore에 파일을 추가할 필요는 없을 거 같아요..!
src/app/(main)/notice/posts/[postId]/_components/PostDetail.tsx
Outdated
Show resolved
Hide resolved
...vity/[semesterId]/[activityId]/boards/[boardId]/posts/[postId]/_components/detail/Detail.tsx
Outdated
Show resolved
Hide resolved
...n)/activity/[semesterId]/[activityId]/boards/[boardId]/create-post/_components/form/Form.tsx
Outdated
Show resolved
Hide resolved
예전에 작성된 코드라서 type으로 사용한 부분이 많네요 ㅎㅎ.. 아래 로직만 변경하느라 놓친 것 같습니다ㅜㅜ 담부턴 주의하겠습니당 |
|
머지머지 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 상세 내용
#️⃣ 이슈 번호
🔗 참고 자료
📷 스크린샷(선택)