-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
issue#82 게시글 리팩토링 #83
Merged
Merged
Changes from 15 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
af2684c
Chore: shadcn Calendar 버전 업그레이드
ppochaco c240c40
Chore: .gitignore에 models 폴더 추가
ppochaco b8cf9a9
Rename: ActivityDateDialog 컴포넌트 위치 수정
ppochaco 33c70b7
Rename: activity create post 관련 컴포넌트 구조 변경
ppochaco edb30ce
Refactor(activity): 활동 게시글 생성하기 request 수정
ppochaco 9fbd3f3
Rename: 활동 게시글 관련 컴포넌트 구조 수정
ppochaco 7b882f5
Refactor: 게시글 공통 table 컴포넌트 props 제너릭으로 수정
ppochaco d19501b
Refactor(activity): 활동 게시글 목록 조회 response 수정
ppochaco 7544591
Refactor(activity): 활동 게시글 단일 조회 API 수정
ppochaco 7727029
Fix: 활동 게시글 생성 후 초기화 할 게시글 목록 query 수정
ppochaco b891bd4
Fix: 게시글 공통 table type 추가
ppochaco 3578f66
Feat: 게시글 삭제 시 확인창 추가
ppochaco 96a149a
Rename(activity): 활동 게시글 단일 조회 관련 컴포넌트 구조 수정
ppochaco 2249191
Refactor(notice): 공지사항 게시글 관련 API 수정
ppochaco 461ff34
Refactor: 게시글 삭제 확인창 공통 컴포넌트로 분리
ppochaco f55c2ac
Fix: 공통 컴포넌트 PostDeleteDialog에 'use-client' 추가
ppochaco 92e1408
Fix: props 타입 interface로 변경
ppochaco 8ab4f74
Fix: props 타입 interface로 변경2
ppochaco File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,4 +32,7 @@ yarn-error.log* | |
|
||
# typescript | ||
*.tsbuildinfo | ||
next-env.d.ts | ||
next-env.d.ts | ||
|
||
# api docs | ||
/src/models |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
66 changes: 0 additions & 66 deletions
66
.../activity/[semesterId]/[activityId]/boards/[boardId]/create-post/_components/PostForm.tsx
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 파일들에 eslint 관련 disable 속성이 많이 적용되어있는것 같은데, eslintignore 파일도 생성해서 무시 파일에 추가하는건 어떨까요?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
해당 파일은 저희가 직접 작성하는 게 아니라, 라이브러리에서 작성해주는 파일이니까 따로 eslintignore에 파일을 추가할 필요는 없을 거 같아요..!