Add cascade delete constraints, allow users to delete their accounts #316

DasSkelett · 2020-08-07T15:57:22Z

Motivation

Every now and then users want to delete their accounts (we should ask for the reason the next time, out of interest).
Every website with the option to create accounts should (and also must) have another option to delete these accounts again.

How and what

There's still the discussion on what we actually want to delete if a user deletes their account.

For know, to get us started, I decided to stay consistent with what we already do and delete everything linked to that user, both in the database and on disk. This means mods of these users are deleted too.

Please continue this discussion in #215 or on the Discord and leave the comments on this PR to actual code review.
I'll update this PR depending on how we decide on that.

Changes

If the user's session cookie has an invalid game id (e.g. if the game has been deleted after it has been set in the cookie) _restore_game_info() threw an exception. Now it returns None.
Some database magic: Added cascade delete constraints to all the relationships / foreign key constraints where it makes sense. This simplifies the deletion of mods (and also deletes some stuff we forgot until now, like download events and follow events), and enables the deletion of user accounts. It'll likely help us in the future too.
This needs a database migration.
Based on this, I added an option for users to delete their accounts in the profile edit page. There's not much to it, I've mostly copied the code from the password change option where possible. To prevent some unfortunate mouse clicks having a devastating effect, you have to enter your username to confirm the deletion.
Admins can also delete users, on the user profile page (where all the other per-user admin infos and options are)

Closes #215

HebaruSan · 2021-11-02T00:30:41Z

What remains to be done here? Do we just need a final decision on what should be deleted, or are there code pieces left?

DasSkelett · 2021-11-02T12:32:15Z

Hm, can't really remember the technical points, maybe the deletion of zips when individual mod versions are deleted had still to be done.
It was mostly the discussion about what to delete that I didn't want to bring up again that kept this WIP.

HebaruSan · 2021-11-02T14:00:40Z

It was mostly the discussion about what to delete that I didn't want to bring up again that kept this WIP.

Would it be easier to proceed if we deferred this decision to a config setting?

HebaruSan · 2021-11-02T15:49:39Z

Should we add cascade deletion to Following.mod_id and Following.user_id?

HebaruSan · 2021-11-02T16:08:51Z

alembic/versions/2021_11_02_14_00_00-7eec82634342.py

+
+
+def upgrade() -> None:
+    op.drop_constraint('downloadevent_version_id_fkey', 'downloadevent', type_='foreignkey')


Would it make sense to try to delete old records that weren't deleted in the past and now have invalid or missing values?

HebaruSan · 2021-11-02T16:42:02Z

templates/profile.html

+        <div class="col-md-6">
+            <h2 title="change-password">Delete User Account</h2>
+        </div>


This 2x2 table layout breaks in a narrow window:

We should try to keep related elements together.

HebaruSan · 2021-11-02T16:58:46Z

KerbalStuff/blueprints/api.py

+    if form_username != username:
+        return {'error': True, 'reason': 'Wrong username'}


Hmm, it doesn't feel right to assume form inputs in an /api/ route. An "API" should be usable by whatever random JSON clients people want to write (e.g. Netkan or Nertea's publishing scripts), not just the front-end.

Instead of checking whether there's a match after the user clicks the Delete confirmation button, could we try this?

The Delete button in the popup starts out disabled (but Cancel is always enabled)

An event handler in the username box checks whether its value is correct, and then enables or disables the Delete button based on that

That way the user could only click the button after they type the name. If some admin wants to delete users with an API script independently, the confirmation flow would not be relevant to them anyway.

This may also make it possible to change the popup form's action to /api/user/{{ profile.username }}/delete and delete most of the new script code.

Hmm, it doesn't feel right to assume form inputs in an /api/ route. An "API" should be usable by whatever random JSON clients people want to write (e.g. Netkan or Nertea's publishing scripts), not just the front-end.

This is pretty normal and standard, we do this in a lot of API routes. That's why they are POSTs. You need some way to transmit data to the server.
I'm not aware of any HTTP client that is incapable of including form data in a POST request. Netkan only reads from the API and doesn't write anything, thus it also doesn't use POSTs. But I'm very confident that WebClient could include form data if it needed to.

Here it is primarily meant as a "confirmation" feature so you don't delete your account accidentally. Whether that's useful for APIs is debatable I guess, I'm okay with removing it. I'm pretty sure that just came from adopting the password change mechanism.

Oh right, the api.md documentation does say:

Submit all POSTS with the request body encoded as
multipart/form-data. Your HTTP library
of choice probably handles that for you. All responses are JSON.

... so using a form input is fine. I guess my objection is just to this one specific form input, then.

Added an implementation of this suggestion in #417, with script code enabling/disabling the button.

HebaruSan · 2021-11-02T17:04:29Z

KerbalStuff/blueprints/api.py

+        if current_user.username == username:
+            deletable = True
+    if not deletable:
+        return {'error': True, 'reason': 'Unauthorized'}


Should we use HTTP status codes for this function's returns? The change password route does this, specifically with 403.

KerbalStuff/blueprints/mods.py

And one for admins

HebaruSan · 2023-03-20T03:22:44Z

Rebased and added a fix for mod_followers to fix 500 errors users have been experiencing at deletion:

Mar 19 15:50:52 sd1a gunicorn[17994]: 2023-03-19 15:50:52,142 ERROR SpaceDock:17994 Dependency rule tried to blank-out primary key column ‘mod_followers.mod_id’ on instance ‘<Following at 0x7f8c8fd720d0>’

Looks like the discussion of what to delete has wound down, and this PR's approach will be fine.

HebaruSan

Nice work, and we need it.

DasSkelett added Area: Backend Related to the Python code that runs inside gunicorn Priority: Normal Type: Feature Status: In Progress Area: Frontend Related to HTML, JS, CSS, or other browser things Area: Migration Related to Alembic database migrations labels Aug 7, 2020

DasSkelett force-pushed the feature/delete-account branch from 38beb90 to 19b18f5 Compare August 7, 2020 18:06

DasSkelett force-pushed the feature/delete-account branch 2 times, most recently from e759e33 to e2c5f16 Compare September 18, 2020 18:25

DasSkelett force-pushed the feature/delete-account branch from e2c5f16 to ff3eda6 Compare January 10, 2021 20:45

DasSkelett force-pushed the feature/delete-account branch from ff3eda6 to ff825ab Compare May 18, 2021 21:08

DasSkelett mentioned this pull request Jun 23, 2021

Speed up DownloadEvent queries #370

Merged

This was referenced Oct 26, 2021

[Feature] Admin users page improvements #413

Closed

Admin users list usability, buttons to delete users #417

Merged

DasSkelett force-pushed the feature/delete-account branch from ff825ab to 6b42944 Compare November 2, 2021 13:09

HebaruSan linked an issue Nov 2, 2021 that may be closed by this pull request

Add Delete Account Option #215

Closed

HebaruSan reviewed Nov 2, 2021

View reviewed changes

HebaruSan added a commit to HebaruSan/SpaceDock that referenced this pull request Nov 2, 2021

Make user type username to delete as in KSP-SpaceDock#316

7164a26

HebaruSan added a commit to HebaruSan/SpaceDock that referenced this pull request Nov 2, 2021

Make user type username to delete as in KSP-SpaceDock#316

f1cf3a4

HebaruSan added the Scope: Large Complex changes requiring a lot of effort to develop and review label Nov 13, 2021

HebaruSan mentioned this pull request Dec 6, 2021

Freeze Cashedowt's mods KSP-CKAN/NetKAN#8898

Merged

HebaruSan reviewed Dec 6, 2021

View reviewed changes

KerbalStuff/blueprints/mods.py Show resolved Hide resolved

Fix _restore_game_info for invalid/deleted game ids

693e953

DasSkelett and others added 2 commits March 20, 2023 02:43

Add cascade delete constraints to several relationships

d94e729

Add option for users to delete their accounts

309896a

And one for admins

HebaruSan force-pushed the feature/delete-account branch from 6b42944 to 309896a Compare March 20, 2023 03:19

HebaruSan marked this pull request as ready for review March 20, 2023 03:19

HebaruSan approved these changes Mar 20, 2023

View reviewed changes

HebaruSan merged commit b858a2e into KSP-SpaceDock:alpha Mar 20, 2023

HebaruSan added a commit to HebaruSan/SpaceDock that referenced this pull request Mar 20, 2023

Make user type username to delete as in KSP-SpaceDock#316

6af46f9

HebaruSan changed the title ~~[WIP] Add cascade delete constraints, allow users to delete their accounts~~ Add cascade delete constraints, allow users to delete their accounts Apr 4, 2023

This was referenced Apr 4, 2023

β → 🜚🏭 Ⅶ #482

Merged

Fix admin user deletion on profile #495

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add cascade delete constraints, allow users to delete their accounts #316

Add cascade delete constraints, allow users to delete their accounts #316

DasSkelett commented Aug 7, 2020 •

edited

Loading

HebaruSan commented Nov 2, 2021

DasSkelett commented Nov 2, 2021

HebaruSan commented Nov 2, 2021 •

edited

Loading

HebaruSan commented Nov 2, 2021 •

edited

Loading

HebaruSan Nov 2, 2021

HebaruSan Nov 2, 2021

HebaruSan Nov 2, 2021 •

edited

Loading

DasSkelett Nov 2, 2021

HebaruSan Nov 2, 2021

HebaruSan Nov 2, 2021

HebaruSan Nov 2, 2021

HebaruSan commented Mar 20, 2023 •

edited

Loading

HebaruSan left a comment



		def upgrade() -> None:
		op.drop_constraint('downloadevent_version_id_fkey', 'downloadevent', type_='foreignkey')

		if form_username != username:
		return {'error': True, 'reason': 'Wrong username'}

Add cascade delete constraints, allow users to delete their accounts #316

Add cascade delete constraints, allow users to delete their accounts #316

Conversation

DasSkelett commented Aug 7, 2020 • edited Loading

Motivation

How and what

Changes

HebaruSan commented Nov 2, 2021

DasSkelett commented Nov 2, 2021

HebaruSan commented Nov 2, 2021 • edited Loading

HebaruSan commented Nov 2, 2021 • edited Loading

HebaruSan Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan Nov 2, 2021 • edited Loading

Choose a reason for hiding this comment

DasSkelett Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan Nov 2, 2021

Choose a reason for hiding this comment

HebaruSan commented Mar 20, 2023 • edited Loading

HebaruSan left a comment

Choose a reason for hiding this comment

DasSkelett commented Aug 7, 2020 •

edited

Loading

HebaruSan commented Nov 2, 2021 •

edited

Loading

HebaruSan commented Nov 2, 2021 •

edited

Loading

HebaruSan Nov 2, 2021 •

edited

Loading

HebaruSan commented Mar 20, 2023 •

edited

Loading