-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Begin The Great Documention #779
base: main
Are you sure you want to change the base?
Conversation
The following fields in the profile columns list have caused me some pain in the past when searching for relevant profiles to study the temperature gradients in a star. In r24.03.1, all these fields are undocumented.
PS: Awesome to see this push to improve the MESA documentation. Many thanks for setting this up! |
@@ -1115,7 +1115,7 @@ | |||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|||
! stop when the center entropy is above/below the upper/lower limit. | |||
! in kerg per baryon | |||
! in kerg per baryon, where kerg = (erg K^-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
! in kerg per baryon, where kerg = (erg K^-1) | |
! in erg per kelvin per baryon |
or
! in kerg per baryon, where kerg = (erg K^-1) | |
! in (erg K^-1) per baryon |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you @warrickball ! It's just that kerg gets used all over in Mesa documentation and output headers, so I think we should correct these all at once. Should we do it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, if it's a reasonably common unit, perhaps we don't need to change it, but I'd never encountered it before.
If we are going to change it in a lot of places at once, I agree with doing it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment from the peanut gallery. i disagree with adding per baryon. electrons, leptons, have an entropy that is added to the total. photons, bosons, also have an entropy that is added in. an entropy of mixing is also added. none of these other contributions to the total entropy have baryons associated with them.
@@ -1129,7 +1129,7 @@ | |||
! ~~~~~~~~~~~~~~~~~~~~~~~ | |||
|
|||
! stop when the max entropy is above/below the upper/lower limit. | |||
! in kerg per baryon | |||
! in kerg per baryon, where kerg = (erg K^-1) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As above:
! in kerg per baryon, where kerg = (erg K^-1) | |
! in erg per kelvin per baryon |
or
! in kerg per baryon, where kerg = (erg K^-1) | |
! in (erg K^-1) per baryon |
@@ -2022,7 +2030,7 @@ | |||
! Pgas_div_P_limit | |||
! ~~~~~~~~~~~~~~~~ | |||
|
|||
! criteria for stopping on Pgas/P | |||
! criteria for stopping when Pgas/P <= Pgas_div_P_limit |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For parity with other similar controls
! criteria for stopping when Pgas/P <= Pgas_div_P_limit | |
! stop when Pgas/P <= Pgas_div_P_limit |
@@ -689,6 +689,8 @@ | |||
! set hydrogen and helium mass fractions according to the following: | |||
! If no h2 in current net, then this will be added to h1. | |||
! If no he3 in current net, then this will be added to he4. | |||
! When ``set_uniform_initial_composition = .false.``, defer to | |||
! composition controls in &controls.defaults. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though we aren't being very consistent about monospace yet, I think this should be
! composition controls in &controls.defaults. | |
! composition controls in ``star/defaults/controls.defaults``. |
The control |
Addressing #766, and serving as a stepping stone for further documentation. I welcome all who would like join this effort by pushing documentation changes/updates into this pr.