Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Begin The Great Documention #779

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

Debraheem
Copy link
Member

@Debraheem Debraheem commented Feb 9, 2025

Addressing #766, and serving as a stepping stone for further documentation. I welcome all who would like join this effort by pushing documentation changes/updates into this pr.

@Debraheem Debraheem added documentation Improvements or additions to documentation release-blocker Things that should be fixed before the next release labels Feb 9, 2025
@Mathijs-Vanrespaille
Copy link

Mathijs-Vanrespaille commented Feb 16, 2025

The following fields in the profile columns list have caused me some pain in the past when searching for relevant profiles to study the temperature gradients in a star. In r24.03.1, all these fields are undocumented.

  • gradL_sub_gradr
  • gradP_div_rho
  • gradT_excess_effect
  • gradT_rel_err
  • gradT_sub_a
  • grada_face
  • grada_sub_gradr
  • diff_grads
  • log_diff_grads
  • mlt_D
  • mlt_Gamma
  • mlt_Y_face
  • mlt_Zeta
  • mlt_gradT
  • mlt_log_abs_Y
  • mlt_vc
  • log_mlt_vc
  • dvc_dt_TDC_div_g

PS: Awesome to see this push to improve the MESA documentation. Many thanks for setting this up!

@@ -1115,7 +1115,7 @@
! ~~~~~~~~~~~~~~~~~~~~~~~~~~

! stop when the center entropy is above/below the upper/lower limit.
! in kerg per baryon
! in kerg per baryon, where kerg = (erg K^-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not just

Suggested change
! in kerg per baryon, where kerg = (erg K^-1)
! in erg per kelvin per baryon

or

Suggested change
! in kerg per baryon, where kerg = (erg K^-1)
! in (erg K^-1) per baryon

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree with you @warrickball ! It's just that kerg gets used all over in Mesa documentation and output headers, so I think we should correct these all at once. Should we do it in this PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, if it's a reasonably common unit, perhaps we don't need to change it, but I'd never encountered it before.

If we are going to change it in a lot of places at once, I agree with doing it in a separate PR.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment from the peanut gallery. i disagree with adding per baryon. electrons, leptons, have an entropy that is added to the total. photons, bosons, also have an entropy that is added in. an entropy of mixing is also added. none of these other contributions to the total entropy have baryons associated with them.

@@ -1129,7 +1129,7 @@
! ~~~~~~~~~~~~~~~~~~~~~~~

! stop when the max entropy is above/below the upper/lower limit.
! in kerg per baryon
! in kerg per baryon, where kerg = (erg K^-1)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As above:

Suggested change
! in kerg per baryon, where kerg = (erg K^-1)
! in erg per kelvin per baryon

or

Suggested change
! in kerg per baryon, where kerg = (erg K^-1)
! in (erg K^-1) per baryon

@@ -2022,7 +2030,7 @@
! Pgas_div_P_limit
! ~~~~~~~~~~~~~~~~

! criteria for stopping on Pgas/P
! criteria for stopping when Pgas/P <= Pgas_div_P_limit
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For parity with other similar controls

Suggested change
! criteria for stopping when Pgas/P <= Pgas_div_P_limit
! stop when Pgas/P <= Pgas_div_P_limit

@@ -689,6 +689,8 @@
! set hydrogen and helium mass fractions according to the following:
! If no h2 in current net, then this will be added to h1.
! If no he3 in current net, then this will be added to he4.
! When ``set_uniform_initial_composition = .false.``, defer to
! composition controls in &controls.defaults.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Though we aren't being very consistent about monospace yet, I think this should be

Suggested change
! composition controls in &controls.defaults.
! composition controls in ``star/defaults/controls.defaults``.

@Mathijs-Vanrespaille
Copy link

The control max_allowed_nz currently has the following documentation:
Maximum number of grid points allowed. Array allowed to grow arbitrarily large if max_allowed_nz <= 0
Please clarify in the documentation what happens if the number of zones goes above this limit. Should the code reduce the number of zones to below the maximum again (if so, how does it do so?) or does the run end? In my experience, an error is thrown and the run ends.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation release-blocker Things that should be fixed before the next release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants