-
Notifications
You must be signed in to change notification settings - Fork 48
Begin The Great Documention #779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
c081ddd
[ci skip] begin The Great Documention
Debraheem 6e1e174
[ci skip] add docs for stopping conditions
Debraheem 817f7db
[ci skip] minor docs changes
pmocz a1d9f9a
[ci skip] docs fixs
pmocz ef53ae6
Merge branch 'main' into feature/Documentation_updates
pmocz ccaaad3
[ci skip] fix whitespace
pmocz 7daefcd
[ci skip] spelling in docs
pmocz 6caadd9
[ci skip]eb adds bad docs
Debraheem ed95001
[ci skip] docs
Debraheem 796d12d
[ci skip] add warrick suggestions, besides kerg.
Debraheem 7d92f81
[ci skip] tweak
Debraheem e8a78c2
Merge branch 'main' into feature/Documentation_updates
Debraheem 12abdbd
Merge branch 'main' into feature/Documentation_updates
Debraheem 6c287e5
[ci skip] more docs
Debraheem 6023001
[ci skip] dash
pmocz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
|
@@ -216,7 +216,7 @@ | |||||||||
! log_directory | ||||||||||
! ~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! for data files about the run | ||||||||||
! directory for data files about the run | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -226,7 +226,7 @@ | |||||||||
! do_history_file | ||||||||||
! ~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! history file is created if this is true | ||||||||||
! a history file is created if this is true | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1105,7 +1105,7 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when the center entropy is above/below the upper/lower limit. | ||||||||||
! in kerg per baryon | ||||||||||
! in kerg per baryon, where kerg = (erg K^-1) | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1119,7 +1119,7 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when the max entropy is above/below the upper/lower limit. | ||||||||||
! in kerg per baryon | ||||||||||
! in kerg per baryon, where kerg = (erg K^-1) | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. As above:
Suggested change
or
Suggested change
|
||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1173,7 +1173,7 @@ | |||||||||
! Lower limits on surface mass fractions. | ||||||||||
! Stop when surface abundance drops below this limit. | ||||||||||
! Can have up to ``num_xa_surface_limits`` of these (see ``star_def`` for value) | ||||||||||
! ``xa_surface_lower_limit_species`` contains an isotope name as defined in ``chem_def.f`` | ||||||||||
! ``xa_surface_lower_limit_species`` contains an isotope name as defined in ``chem_def.f90`` | ||||||||||
! ``xa_surface_lower_limit`` contains the lower limit value | ||||||||||
|
||||||||||
! :: | ||||||||||
|
@@ -1236,7 +1236,7 @@ | |||||||||
! HB_limit | ||||||||||
! ~~~~~~~~ | ||||||||||
|
||||||||||
! For detecting horizontal branch. | ||||||||||
! For detecting when the model has completed the horizontal branch. | ||||||||||
! Only applies when center abundance by mass of h1 is < 1d-4. | ||||||||||
! Stop when the center abundance by mass of he4 drops below this limit. | ||||||||||
|
||||||||||
|
@@ -1288,6 +1288,8 @@ | |||||||||
! star_species_mass_max_limit_iso | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! Stop when a particular species mass in units of Msun exceeds these limits. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
star_species_mass_min_limit = 0 | ||||||||||
|
@@ -1962,6 +1964,9 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when Lnuc/L is greater than this limit. | ||||||||||
! Here, Lnuc refers to the total thermal power from all burning, including photodisintegrations, | ||||||||||
! ``power_nuc_burn`` in the history_columns.list file. | ||||||||||
! L is the luminosity at the photosphere. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -1972,6 +1977,9 @@ | |||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop when Lnuc/L is less than this limit. | ||||||||||
! Here, Lnuc refers to the total thermal power from all burning, including photodisintegrations, | ||||||||||
! ``power_nuc_burn`` in the history_columns.list file. | ||||||||||
! L is the luminosity at the photosphere. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -2012,7 +2020,7 @@ | |||||||||
! Pgas_div_P_limit | ||||||||||
! ~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! criteria for stopping on Pgas/P | ||||||||||
! stop when Pgas/P <= Pgas_div_P_limit | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
@@ -2022,7 +2030,7 @@ | |||||||||
! Pgas_div_P_limit_max_q | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! stop if Pgas/P < this limit at any location with ``q <= Pgas_div_P_limit_max_q`` | ||||||||||
! stop if Pgas/P < Pgas_div_P_limit at any location with ``q <= Pgas_div_P_limit_max_q`` | ||||||||||
! values near unity skip the outer envelope | ||||||||||
|
||||||||||
! :: | ||||||||||
|
@@ -4108,8 +4116,8 @@ | |||||||||
|
||||||||||
D_mix_rotation_min_tau_full_off = 0d0 | ||||||||||
|
||||||||||
! D_mix_rotation_max_tau_full_on | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
! D_mix_rotation_max_tau_full_on | ||||||||||
! ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||||||||||
|
||||||||||
! Use rotational components of ``D_mix`` for locations where tau >= this. | ||||||||||
! For numerical stability, turn off rotational part of ``D_mix`` at very low tau. | ||||||||||
|
@@ -5632,6 +5640,7 @@ | |||||||||
|
||||||||||
! Maximum number of grid points allowed. | ||||||||||
! Array allowed to grow arbitrarily large if max_allowed_nz <= 0 | ||||||||||
! If nz > max_allowed_nz, MESA will prematurely exit and call this error. | ||||||||||
|
||||||||||
! :: | ||||||||||
|
||||||||||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not just
or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree with you @warrickball ! It's just that kerg gets used all over in Mesa documentation and output headers, so I think we should correct these all at once. Should we do it in this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, if it's a reasonably common unit, perhaps we don't need to change it, but I'd never encountered it before.
If we are going to change it in a lot of places at once, I agree with doing it in a separate PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
comment from the peanut gallery. i disagree with adding per baryon. electrons, leptons, have an entropy that is added to the total. photons, bosons, also have an entropy that is added in. an entropy of mixing is also added. none of these other contributions to the total entropy have baryons associated with them.