Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Add missing CODEOWNER package rules #5351

Merged
merged 1 commit into from
Feb 17, 2025
Merged

chore: Add missing CODEOWNER package rules #5351

merged 1 commit into from
Feb 17, 2025

Conversation

Gudahtt
Copy link
Member

@Gudahtt Gudahtt commented Feb 17, 2025

Explanation

CODEOWNER rules have been added for all packages that are currently missing them:

  • example-controllers: These are examples maintained by the wallet framework team.
  • mutlichain-network-controller: This package has been a collaboration between many teams, but for now the owners have been set to the same as the network-controller plus the accounts team (who proposed this controller's creation). We can change this further if appropriate.

References

The multichain-network-controller package was added here: #5215

Changelog

N/A

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've highlighted breaking changes using the "BREAKING" category above as appropriate
  • I've prepared draft pull requests for clients and consumer packages to resolve any breaking changes

@Gudahtt
chore: Add missing CODEOWNER package rules
1a14acb 
CODEOWNER rules have been added for all packages that are currently
missing them:

* `example-controllers`: These are examples maintained by the wallet
framework team.
* `mutlichain-network-controller`: This package has been a
collaboration between many teams, but for now the owners have been set
to the same as the `network-controller` plus the accounts team (who
proposed this controller's creation). We can change this further if
appropriate.
@Gudahtt Gudahtt marked this pull request as ready for review February 17, 2025 19:15
@Gudahtt Gudahtt requested a review from a team as a code owner February 17, 2025 19:15
@Gudahtt Gudahtt mentioned this pull request Feb 17, 2025
Merged
4 tasks
@Gudahtt Gudahtt merged commit 24b1903 into main Feb 17, 2025
135 checks passed
@Gudahtt Gudahtt deleted the add-missing-codeowner-rules branch February 17, 2025 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikesposito mikesposito mikesposito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Gudahtt @mikesposito