This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Show gateway_fee in FederationIdentity #944
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
approved these changes
Jan 5, 2024
|
Will wait for a comment from @futurepaul , this is for him |
AnthonyRonning
requested review from
futurepaul
and removed request for
futurepaul
futurepaul
reviewed
Jan 22, 2024
There was a problem hiding this comment.
this looks good to me data-wise, although I don't see any code in mutiny-wasm so not sure it will show up for the frontend?
also, if we could add a convenience method called get_estimated_fee and I can just put in an mount and get an Option<u64> of your best guess, I can display that as "estimated fee"
Good catch, I assumed it was pulling it for conversion but it's not. |
Merged
|
Done in #995 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.