This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Fedimint v0.2.2 Changes #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benthecarman
approved these changes
Jan 26, 2024
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
2 times, most recently
from
df1f82d to
f236ccd
Compare
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
from
790852a to
08933c2
Compare
|
Need to not delete the fedimint data itself, in case the user adds the same federation again later. Edit: Done |
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
from
892099b to
a12f95b
Compare
There was a problem hiding this comment.
looks like you moved over the commit from #944 but did not do @futurepaul's comment: #944 (review)
otherwise lgtm
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
2 times, most recently
from
3893d6c to
848c3f3
Compare
Sure I'll add some stuff there today. |
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
4 times, most recently
from
42db752 to
7f2e6f6
Compare
benthecarman
suggested changes
Feb 1, 2024
|
When testing noticed we get 2 activity items here: Would be good to add some sort of way so we can mark these as a single swap item. At the very least could add a label to the invoice so it doesn't just show up as unknown |
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
2 times, most recently
from
9a61026 to
cbdc2e7
Compare
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
from
cbdc2e7 to
e561f25
Compare
AnthonyRonning
force-pushed
the
fedimint-v0.2.2
branch
from
e561f25 to
2747564
Compare
|
I added swap labels but they only work on the outgoing payment. |
benthecarman
approved these changes
Feb 1, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #988
Fixes #975
Fixes #976
Fixes #997
Fixes #911
Fixes #912