This repository was archived by the owner on Feb 3, 2025. It is now read-only.
Change archive contact to delete contact #962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This doesn't work well with fedimint labels, not sure what the status on storage for fedimint stuff is cc @TonyGiorgio |
Not sure. I'll look into it more later. |
|
can revisit this now that fedimint has moved to indexed db |
AnthonyRonning
approved these changes
Jan 23, 2024
benthecarman
force-pushed
the
delete-contact
branch
from
81c0e28 to
8a1f335
Compare
benthecarman
force-pushed
the
delete-contact
branch
from
8a1f335 to
877b6ca
Compare
|
Tested and this now works with fedimint payments |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous iteration just archived which made things ugly for the front end afterwards. This is cleaner and makes thing simpler for everyone