Fix YAML multiline config for package names #358
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
needs #360 to be merged before for checks to succeed. |
* Use '>-' instead of '>' for YAML multline when creating package names. The extra newline at the end of the string can cause JSON parsing errors as reported by @cbeaujoin-stellar . This change will strip the newline character after the name fixes #357
tbauriedel
force-pushed
the
fix/yaml-multiline-packagename-357
branch
from
b41a269 to
0d99a03
Compare
|
@widhalmt is this still a draft or ready for review? |
|
@tbauriedel I wanted to wait for the checks to run through. My problem with this PR is that it might solve a problem that was reported by a user but I can't reproduce the problem. So - when checks run through I guess we can merge it because as far as I see it does no harm and is indeed the "correct" way to handle this. |
|
@widhalmt Maybe we should add more to the Issue Template. |
|
If you mark the PR 'ready' I can give you the approval. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently I can't reproduce the error that is shown in the issue. Since it's a simple fix I provided a PR anyway but we need to test this more before we merge it.
The extra newline at the end of the string can cause JSON parsing errors as reported by @cbeaujoin-stellar .
This change will strip the newline character after the name
fixes #357