Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix YAML multiline config for package names #358

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/beats/tasks/auditbeat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- name: Construct exact name of Auditbeat package
ansible.builtin.set_fact:
beats_auditbeat_package: >
beats_auditbeat_package: >-
{{
'auditbeat' +
(elasticstack_versionseparator +
Expand Down Expand Up @@ -59,7 +59,7 @@
- name: Install Auditbeat latest version - rpm - standalone
ansible.builtin.package:
name: auditbeat
state: latest

Check warning on line 62 in roles/beats/tasks/auditbeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Auditbeat
when:
Expand All @@ -71,7 +71,7 @@
- name: Install Auditbeat latest version - deb
ansible.builtin.package:
name: auditbeat
state: latest

Check warning on line 74 in roles/beats/tasks/auditbeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Auditbeat
when:
Expand Down
2 changes: 1 addition & 1 deletion roles/beats/tasks/filebeat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- name: Construct exact name of Filebeat package
ansible.builtin.set_fact:
beats_filebeat_package: >
beats_filebeat_package: >-
{{
'filebeat' +
(elasticstack_versionseparator +
Expand Down Expand Up @@ -41,7 +41,7 @@
- name: Install Filebeat latest version - rpm - full stack
ansible.builtin.package:
name: filebeat
state: latest

Check warning on line 44 in roles/beats/tasks/filebeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
enablerepo:
- "elastic-{{ elasticstack_release }}.x"
notify:
Expand All @@ -55,7 +55,7 @@
- name: Install Filebeat latest version - rpm - standalone
ansible.builtin.package:
name: filebeat
state: latest

Check warning on line 58 in roles/beats/tasks/filebeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Filebeat
when:
Expand All @@ -67,7 +67,7 @@
- name: Install Filebeat latest version - deb
ansible.builtin.package:
name: filebeat
state: latest

Check warning on line 70 in roles/beats/tasks/filebeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Filebeat
when:
Expand Down
2 changes: 1 addition & 1 deletion roles/beats/tasks/metricbeat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

- name: Construct exact name of Metricbeat package
ansible.builtin.set_fact:
beats_metricbeat_package: >
beats_metricbeat_package: >-
{{
'metricbeat' +
(elasticstack_versionseparator +
Expand Down Expand Up @@ -42,7 +42,7 @@
- name: Install Metricbeat latest version - rpm - full stack
ansible.builtin.package:
name: metricbeat
state: latest

Check warning on line 45 in roles/beats/tasks/metricbeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
enablerepo:
- "elastic-{{ elasticstack_release }}.x"
notify:
Expand All @@ -56,7 +56,7 @@
- name: Install Metricbeat latest version - rpm - standalone
ansible.builtin.package:
name: metricbeat
state: latest

Check warning on line 59 in roles/beats/tasks/metricbeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Metricbeat
when:
Expand All @@ -69,7 +69,7 @@
- name: Install Metricbeat latest version - deb
ansible.builtin.package:
name: metricbeat
state: latest

Check warning on line 72 in roles/beats/tasks/metricbeat.yml

View workflow job for this annotation

GitHub Actions / kics

[LOW] Unpinned Package Version

Setting state to latest performs an update and installs additional packages possibly resulting in performance degradation or loss of service
notify:
- Restart Metricbeat
when:
Expand Down
2 changes: 1 addition & 1 deletion roles/kibana/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@

- name: Construct exact name of Kibana package
ansible.builtin.set_fact:
kibana_package: >
kibana_package: >-
{{
'kibana' +
('-oss' if elasticstack_variant == 'oss' else '') +
Expand Down
4 changes: 2 additions & 2 deletions roles/logstash/tasks/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@

- name: Construct exact name of Logstash package
ansible.builtin.set_fact:
logstash_package: >
logstash_package: >-
{{
'logstash' +
('-oss' if elasticstack_variant == 'oss' else '') +
Expand All @@ -72,7 +72,7 @@

- name: Construct exact name of Logstash package
ansible.builtin.set_fact:
logstash_package: >
logstash_package: >-
{{
'logstash' +
('-oss' if elasticstack_variant == 'oss' else '') +
Expand Down
Loading