Phase 1 validation: adpsfc (181/281) yamls #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
delippi
requested review from
hu5970,
ShunLiu-NOAA,
guoqing-noaa,
spanNOAA and
SamuelDegelia-NOAA
ShunLiu-NOAA
previously approved these changes
Feb 14, 2025
| obsdatain: | ||
| engine: | ||
| type: H5File | ||
| #obsfile: "@OBSFILE@" |
There was a problem hiding this comment.
Could we set this (and in the other yamls) back to the replaceable @OBSFILE@ string? Other than that, it looks good to me.
There was a problem hiding this comment.
My bad, I meant to do that before committing.
SamuelDegelia-NOAA
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adpsfc yaml passed phase 1 validation. The point of this PR is to establish the yaml in RDASApp. This won't affect cycling DA results because we will only use configurations that have passed phase 3 validation.
Issue(s) addressed
Checklist