-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase 1 validation: adpsfc (181/281) yamls #283
Open
delippi
wants to merge
4
commits into
NOAA-EMC:develop
Choose a base branch
from
delippi:feature/phase1_adpsfc81
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
b67838a
Saving progress with adpsfc81 after phase 1 complete.
delippi bb25639
forgot to capture the new recommended halo size.
delippi 4ff007b
uncomment the @OBSFILE@ and comment the phase1 obsfile name.
delippi 20fb434
missed a comment for the phase1 obsfile name.
delippi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
276 changes: 276 additions & 0 deletions
276
rrfs-test/validated_yamls/templates/obtype_config/adpsfc_airTemperature_181.yaml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,276 @@ | ||
- obs space: | ||
name: adpsfc_airTemperature_181 | ||
distribution: | ||
name: "@DISTRIBUTION@" | ||
halo size: 300e3 | ||
obsdatain: | ||
engine: | ||
type: H5File | ||
#obsfile: "@OBSFILE@" | ||
obsfile: "obsout/sfc_tsen_obs_2024052700_dc.nc4" | ||
obsgrouping: | ||
group variables: ["stationIdentification"] | ||
sort variable: "pressure" | ||
sort order: "descending" | ||
obsdataout: | ||
engine: | ||
type: H5File | ||
obsfile: jdiag_adpsfc_airTemperature_181.nc4 | ||
allow overwrite: true | ||
io pool: | ||
max pool size: 1 | ||
observed variables: [airTemperature] | ||
simulated variables: [airTemperature] | ||
|
||
obs operator: | ||
name: VertInterp | ||
vertical coordinate: air_pressure | ||
observation vertical coordinate: pressure | ||
observation vertical coordinate group: MetaData | ||
interpolation method: log-linear | ||
#gsi geovals: | ||
# filename: "obsout/sfc_tsen_geoval_2024052700.nc4" | ||
# levels_are_top_down: False | ||
variables: | ||
- name: airTemperature | ||
|
||
linear obs operator: | ||
name: VertInterp | ||
|
||
obs error: | ||
covariance model: diagonal | ||
|
||
obs localizations: | ||
- localization method: Horizontal Gaspari-Cohn | ||
lengthscale: 300e3 # orig | ||
|
||
obs filters: | ||
# ------------------ | ||
# airTemperature (181) | ||
# ------------------ | ||
# Reject all obs with QualityMarker > 3 | ||
- filter: Perform Action | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
where: | ||
- variable: QualityMarker/airTemperature | ||
is_in: 4-15 | ||
action: | ||
name: reject | ||
action: | ||
name: reduce obs space | ||
|
||
# Time window filter | ||
- filter: Domain Check | ||
apply at iterations: 0,1 | ||
where: | ||
- variable: | ||
name: MetaData/timeOffset # units: s | ||
minvalue: -900 | ||
maxvalue: 900 | ||
action: | ||
name: reduce obs space | ||
|
||
# Duplicate Check | ||
- filter: Temporal Thinning | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
min_spacing: PT90M | ||
tolerance: PT0H | ||
seed_time: "2024-05-27T00:00:00Z" | ||
category_variable: | ||
name: MetaData/longitude_latitude_pressure | ||
action: | ||
name: reduce obs space | ||
|
||
# Online regional domain check | ||
- filter: Bounds Check | ||
filter variables: | ||
- name: airTemperature | ||
test variables: | ||
- name: GeoVaLs/observable_domain_mask | ||
minvalue: 0.0 | ||
maxvalue: 0.5 | ||
|
||
# Initial error assignment | ||
- filter: Perform Action | ||
filter variables: | ||
- name: airTemperature | ||
where: | ||
- variable: ObsType/airTemperature | ||
is_in: 181 | ||
action: | ||
name: assign error | ||
error function: | ||
name: ObsFunction/ObsErrorModelStepwiseLinear | ||
options: | ||
xvar: | ||
name: MetaData/pressure | ||
xvals: [110000, 105000, 100000, 95000, 90000, 85000, 80000, 75000, 70000, 65000, 60000, 55000, 50000, 45000, 40000, 35000, 30000, 25000, 20000, 15000, 10000, 7500, 5000, 4000, 3000, 2000, 1000, 500, 400, 300, 200, 100, 0] | ||
errors: [0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528, 0.7528] | ||
#errors: [1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056, 1.5056] | ||
|
||
# # Error inflation based on pressure check (setupt.f90) | ||
# - filter: Perform Action | ||
# filter variables: | ||
# - name: airTemperature | ||
# where: | ||
# - variable: ObsType/airTemperature | ||
# is_in: 181 | ||
# action: | ||
# name: inflate error | ||
# inflation variable: | ||
# name: ObsFunction/ObsErrorFactorPressureCheck | ||
# options: | ||
# variable: airTemperature | ||
# inflation factor: 8.0 | ||
|
||
# # Error inflation based on errormod (qcmod.f90) | ||
# - filter: Perform Action | ||
# filter variables: | ||
# - name: airTemperature | ||
# where: | ||
# - variable: ObsType/airTemperature | ||
# is_in: 181 | ||
# action: | ||
# name: inflate error | ||
# inflation variable: | ||
# name: ObsFunction/ObsErrorFactorConventional | ||
# options: | ||
# inflate variables: [airTemperature] | ||
# pressure: MetaData/pressure | ||
|
||
# Error inflation when QualityMarker == 3 (read_prepbufr.f90) | ||
- filter: Perform Action | ||
filter variables: | ||
- name: airTemperature | ||
action: | ||
name: inflate error | ||
inflation factor: 1.2 | ||
where: | ||
- variable: QualityMarker/airTemperature | ||
is_in: 3 | ||
|
||
# Error inflation when observation pressure < 100 hPa (read_prepbufr.f90) | ||
- filter: Perform Action | ||
filter variables: | ||
- name: airTemperature | ||
action: | ||
name: inflate error | ||
inflation factor: 1.2 | ||
where: | ||
- variable: MetaData/pressure | ||
maxvalue: 10000.0 | ||
|
||
# Bounds Check (ObsError) | ||
- filter: Bounds Check | ||
filter variables: | ||
- name: airTemperature | ||
test variables: | ||
- name: ObsErrorData/airTemperature | ||
minvalue: 0.0 | ||
action: | ||
name: reduce obs space | ||
|
||
# Bounds Check (ObsValue) | ||
- filter: Bounds Check | ||
filter variables: | ||
- name: airTemperature | ||
minvalue: 100 | ||
maxvalue: 400 | ||
action: | ||
name: reduce obs space | ||
|
||
# Create temporary ObsErrorData | ||
- filter: Variable Assignment | ||
apply at iterations: 0,1 | ||
assignments: | ||
- name: TempObsErrorData/airTemperature | ||
type: float | ||
function: | ||
name: ObsFunction/Arithmetic | ||
options: | ||
variables: | ||
- name: ObsErrorData/airTemperature | ||
defer to post: true | ||
|
||
# Set ObsError set "error parameter" if < "max value" | ||
- filter: Perform Action | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
action: | ||
name: assign error | ||
error parameter: 1.0 | ||
where: | ||
- variable: | ||
name: ObsErrorData/airTemperature | ||
maxvalue: 1.0 | ||
- variable: | ||
name: ObsErrorData/airTemperature | ||
value: is_valid | ||
defer to post: true | ||
|
||
# Set ObsError set "error parameter" if > "min value" | ||
- filter: Perform Action | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
action: | ||
name: assign error | ||
error parameter: 3.0 | ||
where: | ||
- variable: | ||
name: ObsErrorData/airTemperature | ||
minvalue: 3.0 | ||
- variable: | ||
name: ObsErrorData/airTemperature | ||
value: is_valid | ||
defer to post: true | ||
|
||
# Gross Error Check | ||
- filter: Background Check | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
threshold: 5.0 | ||
action: | ||
name: reject | ||
where: | ||
- variable: ObsType/airTemperature | ||
- variable: QualityMarker/airTemperature | ||
is_not_in: 3 | ||
defer to post: true | ||
|
||
# Gross Error Check: cgross*0.7 if QualityMarker=3 | ||
- filter: Background Check | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
threshold: 3.5 | ||
action: | ||
name: reject | ||
where: | ||
- variable: ObsType/airTemperature | ||
- variable: QualityMarker/airTemperature | ||
is_in: 3 | ||
defer to post: true | ||
|
||
# Re-assign err ObsErrorData <--- TempObsErrorData after gross error check. | ||
- filter: Perform Action | ||
apply at iterations: 0,1 | ||
filter variables: | ||
- name: airTemperature | ||
action: | ||
name: assign error | ||
error function: TempObsErrorData/airTemperature | ||
where: | ||
- variable: | ||
name: TempObsErrorData/airTemperature | ||
value: is_valid | ||
defer to post: true | ||
|
||
#- filter: GOMsaver | ||
# filename: ./data/geovals/adpsfc_geovals_rrfs.nc4 |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we set this (and in the other yamls) back to the replaceable
@OBSFILE@
string? Other than that, it looks good to me.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My bad, I meant to do that before committing.