CCPP physics: wet() bug fix and workaround for bad tsfco #916
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
jkbk2004
pushed a commit
that referenced
this pull request
Feb 12, 2025
… bug fix and workaround for bad tsfco #916 (#896) * Parallel IO enhancements from GDIT * Add SW clear-sky downward flux at surface to available diagnostics * fix compilation error in GFS_diagnostics.F90 * update atmos_cubed_sphere to turn ENABLE_PARALLELRESTART OFF by default to avoid RT errors on some platforms (Hera, Hercules at least) * ccpp-physics - wet() bug fix and workaround for bad tsfco --------- Co-authored-by: Dustin Swales <[email protected]> Co-authored-by: Samuel Trahan <samuel,[email protected]>
|
@DusanJovic-NOAA This was combined into #896 so it can be closed when you get a chance. |
LarissaReames-NOAA
pushed a commit
to LarissaReames-NOAA/fv3atm
that referenced
this pull request
Feb 12, 2025
… bug fix and workaround for bad tsfco NOAA-EMC#916 (NOAA-EMC#896) * Parallel IO enhancements from GDIT * Add SW clear-sky downward flux at surface to available diagnostics * fix compilation error in GFS_diagnostics.F90 * update atmos_cubed_sphere to turn ENABLE_PARALLELRESTART OFF by default to avoid RT errors on some platforms (Hera, Hercules at least) * ccpp-physics - wet() bug fix and workaround for bad tsfco --------- Co-authored-by: Dustin Swales <[email protected]> Co-authored-by: Samuel Trahan <samuel,[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes this problem:
It was caused by missing values (-1e+20) for sea surface temperature on
wetpoints in input data. (Wetpoints are points where the CCPPwetarray is true, thus indicating the surface is at least partly water.) There's a bug fix and a workaround:wetarray can be mistakenly true when it should be false due to the location being 100% ice. An "else" statement corrects this.wetpoint, the lowest model level temperature is used instead.There is no other temperature available on those points that can reasonably be used as a sea surface temperature. The lowest model level temperature may not be a perfect analogue for the sea surface temperature, but it'll be more realistic than -1E+20 K.
Issue(s) addressed
Testing
How were these changes tested?
What compilers / HPCs was it tested with?
Hera.
Are the changes covered by regression tests? (If not, why? Do new tests need to be added?)
A lower-resolution version of this configuration has a regression test.
This specific input that causes a problem is too high a resolution to be a regression test. Also, this problem likely originates from trouble with the initial conditions. We don't need to test the model with potentially problematic input.
Have the ufs-weather-model regression test been run? On what platform?
Hera.
Will the code updates change regression test baseline? If yes, why? Please show the baseline directory below.
No.
Dependencies
Requirements before merging