Build docs in GitHub for review #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mike McKiernan <[email protected]>
|
If we've restricted the names of the workflows and actions that are allowed, please add nvidia-merlin/.github/. |
Signed-off-by: Mike McKiernan <[email protected]>
Signed-off-by: Mike McKiernan <[email protected]>
Pouyanpi
reviewed
Jan 28, 2025
There was a problem hiding this comment.
Tested 👍🏻
during docs build there are several warnings but I'm sure you expect them for now.
4 tasks
|
Closing in favor of #956. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Build the docs during PRs so we can review the doc updates in GitHub.
Related Issue(s)
Checklist