-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build docs with docs deps and make #956
Conversation
Signed-off-by: Mike McKiernan <[email protected]>
Signed-off-by: Mike McKiernan <[email protected]>
Signed-off-by: Mike McKiernan <[email protected]>
I can't explain why the PR preview job isn't running and isn't visible. I'm OK with troubleshooting that after merging this one or #954. The goal of this PR is so the engineers contributing to the project can choose what they feel is the best developer experience. I have a history of favoring containers for building docs, but if the dev experience is to use poetry and a venv, I'm game. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is GREAT! 🥇
Thank you @mikemckiernan , let's merge it and see how it goest 👍🏻
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
for later, maybe just trigger it when there is a change to docs
dir, .md
or rst
file?
paths:
- 'docs/**'
- '**/*.md'
- '**/*.rst'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is worth doing now, IMO.
Signed-off-by: Mike McKiernan <[email protected]>
Description
Build the docs for PRs, merges to develop, and tags.
Related Issue(s)
Checklist