Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

entitystore controller unittests #301

Merged
merged 2 commits into from
Jan 30, 2025
Merged

entitystore controller unittests #301

merged 2 commits into from
Jan 30, 2025

Conversation

varunrsekar
Copy link
Collaborator

@varunrsekar varunrsekar commented Jan 27, 2025 •
edited
Loading

This change removes unnecessary field authSecret from the CR and introduces unittests for the entitystore controller:

  • CR spec validation tests
  • Controller verification for entitystore deployment creation
  • Also includes util to cleanup child entities from CR creation
  • Also fixes copyright year for ES

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Jan 27, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@varunrsekar varunrsekar force-pushed the es-tests branch 5 times, most recently from fd78620 to 4e1c50a Compare January 28, 2025 20:08
@varunrsekar
entitystore controller unittests
01c8bc9 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@varunrsekar
fix copyright year for nemo entitystore
2b74cd5 
Signed-off-by: Varun Ramachandra Sekar <[email protected]>
@shivamerla shivamerla merged commit 3bf1cb2 into NVIDIA:main Jan 30, 2025
9 checks passed
@varunrsekar varunrsekar deleted the es-tests branch January 30, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shivamerla shivamerla shivamerla approved these changes

@ArangoGutierrez ArangoGutierrez Awaiting requested review from ArangoGutierrez ArangoGutierrez is a code owner

@slu2011 slu2011 Awaiting requested review from slu2011 slu2011 is a code owner

@visheshtanksale visheshtanksale Awaiting requested review from visheshtanksale visheshtanksale is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@varunrsekar @shivamerla