Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

entitystore controller unittests #301

Merged
merged 2 commits into from
Jan 30, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions api/apps/v1alpha1/nemo_entitystore_types.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down Expand Up @@ -54,12 +54,10 @@ const (

// NemoEntitystoreSpec defines the desired state of NemoEntitystore
type NemoEntitystoreSpec struct {
Image Image `json:"image,omitempty"`
Command []string `json:"command,omitempty"`
Args []string `json:"args,omitempty"`
Env []corev1.EnvVar `json:"env,omitempty"`
// The name of an secret that contains authn for the NGC NIM service API
AuthSecret string `json:"authSecret"`
Image Image `json:"image,omitempty"`
Command []string `json:"command,omitempty"`
Args []string `json:"args,omitempty"`
Env []corev1.EnvVar `json:"env,omitempty"`
Labels map[string]string `json:"labels,omitempty"`
Annotations map[string]string `json:"annotations,omitempty"`
NodeSelector map[string]string `json:"nodeSelector,omitempty"`
Expand Down
5 changes: 0 additions & 5 deletions bundle/manifests/apps.nvidia.com_nemoentitystores.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ spec:
items:
type: string
type: array
authSecret:
description: The name of an secret that contains authn for the NGC
NIM service API
type: string
command:
items:
type: string
Expand Down Expand Up @@ -2157,7 +2153,6 @@ spec:
format: int64
type: integer
required:
- authSecret
- databaseConfig
type: object
status:
Expand Down
5 changes: 0 additions & 5 deletions config/crd/bases/apps.nvidia.com_nemoentitystores.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ spec:
items:
type: string
type: array
authSecret:
description: The name of an secret that contains authn for the NGC
NIM service API
type: string
command:
items:
type: string
Expand Down Expand Up @@ -2157,7 +2153,6 @@ spec:
format: int64
type: integer
required:
- authSecret
- databaseConfig
type: object
status:
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,10 +55,6 @@ spec:
items:
type: string
type: array
authSecret:
description: The name of an secret that contains authn for the NGC
NIM service API
type: string
command:
items:
type: string
Expand Down Expand Up @@ -2157,7 +2153,6 @@ spec:
format: int64
type: integer
required:
- authSecret
- databaseConfig
type: object
status:
Expand Down
2 changes: 1 addition & 1 deletion internal/controller/nemo_entitystore_controller.go
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
Copyright 2024.
Copyright 2025.

Licensed under the Apache License, Version 2.0 (the "License");
you may not use this file except in compliance with the License.
Expand Down
Loading