Use GO API for toolkit installation #704
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
elezar
force-pushed
the
use-go-api-for-toolkit-installation
branch
2 times, most recently
from
31ca649 to
43f3ad5
Compare
tariq1890
approved these changes
Sep 27, 2024
|
I was able to validate these changes in gpu-operator after setting the I've filed a PR in gpu-operator to consume this change: NVIDIA/gpu-operator#1019 |
tariq1890
reviewed
Sep 28, 2024
|
|
||
| options := options{} | ||
| options := options{ | ||
| toolkitOptions: toolkit.Options{}, |
There was a problem hiding this comment.
Do we also need this?
Suggested change
| toolkitOptions: toolkit.Options{}, | |
| toolkitOptions: toolkit.Options{}, | |
| runtimeOptions: runtime.Options{}, |
This change converts the toolkit installation logic to a go package and invokes this installation over the go API instead of starting this executable. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
elezar
force-pushed
the
use-go-api-for-toolkit-installation
branch
from
43f3ad5 to
fd708cd
Compare
|
Opened a rebased version of this from my fork #722 |
|
Closing as this is superseded by #722 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change switches from invoking the
toolkit installcommand when installing the NVIDIA Container Toolkit from the toolkit container to invoking the GO API directly.This is also done for the
{{ .Runtime }} setupand{{ .Runtime }} cleanupcommands.This allows for a clearer dependence between the runtime installation and configuration and the toolkit installation.
Note that this assumes that the generic envvars are used instead of
DOCKER_,CONTAINERD_,CRIO_envvars where applicable and also drops support for theRUNTIME_ARGSenvvar. This should be validated with the GPU Operator versions that we expect to consume this.