Use GO API for toolkit installation [rebased] #722
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change converts the toolkit installation logic to a go package and invokes this installation over the go API instead of starting this executable. Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
Signed-off-by: Evan Lezar <[email protected]>
tariq1890
changed the title
cdesiniotis
approved these changes
Sep 30, 2024
dlorenc
added a commit
to wolfi-dev/os
that referenced
this pull request
Nov 17, 2024
These have been merged into the main binary upstream: NVIDIA/nvidia-container-toolkit#722 Signed-off-by: Dan Lorenc <[email protected]>
OddBloke
added a commit
to wolfi-dev/os
that referenced
this pull request
Jan 23, 2025
Upstream have integrated these into the main build since 1.16.x: * NVIDIA/nvidia-container-toolkit#722 * NVIDIA/nvidia-container-toolkit#765
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased version of #704