Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set version of notebooks automatically to latest #33

Merged
merged 2 commits into from
Aug 19, 2024
Merged

fix: set version of notebooks automatically to latest #33

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5878c40
fix: set version of notebooks automatically to latest
jcabrero Aug 7, 2024
4351af8
Merge branch 'main' into fix/set_notebook_version_to_latest
jcabrero Aug 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/complex_model/complex_model.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
},
"outputs": [],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
Copy link
Contributor

@mathias-nillion mathias-nillion Aug 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jcabrero should we instead solve this by specifying a version for both nada and nada-ai? Here we implicitly assume that nada-ai:latest will always work with nada:latest and the specific logic in this notebook

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a hard question. There are pros/cons for each of those and it's hard to tell. I would argue that always being par with nada-dsl is what requires the least work as the API should slowly settle down. However, if we fix versions, every two weeks (or once there's a new release) we need to dedicate a whole morning at least to update all the versions manually and verify that everything works. Not sure what's best here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am going to merge this for now, but it's a good discussion to have and see what's best.

]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/conv_net/conv_net.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}
],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/linear_regression/linear_regression.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}
],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/neural_net/neural_net.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}
],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/spam_detection/spam_detection.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}
],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
]
},
{
Expand Down
2 changes: 1 addition & 1 deletion examples/time_series/time_series.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@
}
],
"source": [
"%pip install nada-ai~=0.3.0 --quiet"
"%pip install nada-ai --quiet"
]
},
{
Expand Down
Loading