Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slimevr: init at 0.13.2 #355597

Closed
wants to merge 2 commits into from
Closed

slimevr: init at 0.13.2 #355597

wants to merge 2 commits into from

Conversation

ImUrX
Copy link
Contributor

@ImUrX ImUrX commented Nov 13, 2024

SlimeVR is used for full-body tracking on VR and is usable with multiple ways of tracking.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 24.11 Release Notes (or backporting 23.11 and 24.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ImUrX
Copy link
Contributor Author

ImUrX commented Nov 13, 2024

Currently have issues with the webview not rendering correctly but it does work and I'm supposing it happens because GTK shenanigans. I'm guessing if I cherry-pick this commit to my current branch I use for my NixOS it probably will work but I dunno if that's how it's supposed to work or if it is not.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 13, 2024
@ImUrX
Copy link
Contributor Author

ImUrX commented Nov 13, 2024

Currently have issues with the webview not rendering correctly but it does work and I'm supposing it happens because GTK shenanigans. I'm guessing if I cherry-pick this commit to my current branch I use for my NixOS it probably will work but I dunno if that's how it's supposed to work or if it is not.

yup seems to work if i cherry pick it and use it with my current nixpkgs, so i guess this is ready for review

@ImUrX ImUrX marked this pull request as ready for review November 13, 2024 21:30
@ImUrX ImUrX force-pushed the slimevr branch 2 times, most recently from c875161 to cf6bc91 Compare November 13, 2024 22:19
@ImUrX
Copy link
Contributor Author

ImUrX commented Nov 13, 2024

Added @C0D3-M4513R as co-maintainer as he is the original creator of the build script and I just improved upon it with permission

@C0D3-M4513R
Copy link
Contributor

I agree to be added as a maintainer and I agree to re-license all the build code nessesary under https://github.com/C0D3-M4513R/slimevr-nixos/

@C0D3-M4513R
Copy link
Contributor

C0D3-M4513R commented Nov 13, 2024

An auto-update from the latest github release is missing.
In #320999 it was: passthru.updateScript = nix-update-script { };

@C0D3-M4513R
Copy link
Contributor

Also, just another concern, but does the correct version get displayed in the gui?
I remember needing do do some replacements for that in 0.13.0: https://github.com/C0D3-M4513R/slimevr-nixos/blob/aea8be98ec2a9be2c0fbda8ed70e92a6cf2c3741/packages/slimevr-server/default.nix#L46-L67

@ImUrX
Copy link
Contributor Author

ImUrX commented Nov 14, 2024

of course, because the gui is downloaded from releases, we just build the binary

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 14, 2024
@gale-username
Copy link
Contributor

gale-username commented Nov 18, 2024

@ImUrX @C0D3-M4513R I just finished updating my version and opened a PR at #356873. The main differences are that everything is built from source and a separate slimevr-server package is provided. I included both of you in the maintainers list, but please tell me if you don't want that.
I'd also appreciate it if you can give the PR a look over and make sure it works well for you.

@ImUrX
Copy link
Contributor Author

ImUrX commented Nov 20, 2024

i guess a fully-source compiled codebase is better than a mixed one, will leave this open but anyone with permissions may close it.

@github-actions github-actions bot removed the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Dec 4, 2024
@ImUrX ImUrX closed this Dec 4, 2024
@ImUrX ImUrX deleted the slimevr branch December 4, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants