Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slimevr, slimevr-server: init at 0.13.2 #356873

Merged
merged 4 commits into from
Dec 14, 2024

Conversation

gale-username
Copy link
Contributor

@gale-username gale-username commented Nov 18, 2024

SlimeVR is used for full-body tracking in VR with a variety of hardware modules and configurations. More information can be found at https://docs.slimevr.dev/.

This PR is similar to #355597, but everything is built from source. slimevr-server is also provided as a separate package, since it's often used independently.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added the 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` label Nov 18, 2024
@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Nov 18, 2024
@gale-username
Copy link
Contributor Author

I'm really not sure how to satisfy the nixpkgs-vet with multiple packages from the same src under by-name. I think this is right from reading https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md, but maybe not.

@ofborg ofborg bot added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Nov 18, 2024
@C0D3-M4513R
Copy link
Contributor

Sorry, I do not feel like being a maintainer for this package. Building everything from source is finicky for slimevr.
I do not want to deal with the amount of breakages that come as a result of that.

@gale-username gale-username force-pushed the slimevr branch 2 times, most recently from 0a57b1c to 3fd73cf Compare November 18, 2024 23:31
@gale-username
Copy link
Contributor Author

Sorry, I do not feel like being a maintainer for this package. Building everything from source is finicky for slimevr. I do not want to deal with the amount of breakages that come as a result of that.

Indeed was very annoying to get working well. I appreciate your work on this.

@ImUrX
Copy link
Contributor

ImUrX commented Nov 20, 2024

I don't think I would be able to update this manually every update without the update script when I already take care of it on actual SlimeVR releases

@ImUrX
Copy link
Contributor

ImUrX commented Nov 20, 2024

I'm really not sure how to satisfy the nixpkgs-vet with multiple packages from the same src under by-name. I think this is right from reading https://github.com/NixOS/nixpkgs/blob/master/pkgs/by-name/README.md, but maybe not.

from what i understand each package should have its own directory instead of sharing it with another one, guessing that from how most unwrapped packages are not on the same directory as their wrapped counterparts

@pluiedev
Copy link
Contributor

Also I think it'd be better if the commit can be split in two for slimevr and slimevr-server respectively

@ofborg ofborg bot requested a review from ImUrX November 23, 2024 00:57
@FliegendeWurst FliegendeWurst added the awaiting_changes (old Marvin label, do not use) label Dec 6, 2024
@FliegendeWurst FliegendeWurst removed the awaiting_changes (old Marvin label, do not use) label Dec 8, 2024
@FliegendeWurst FliegendeWurst merged commit fbcc335 into NixOS:master Dec 14, 2024
41 of 42 checks passed
@ImUrX
Copy link
Contributor

ImUrX commented Dec 14, 2024

yay

@gale-username gale-username deleted the slimevr branch December 14, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants