python312Packages.textual: 0.86.1 -> 1.0.0 #370103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcboy
force-pushed
the
upgrade-textual-1.0.0
branch
2 times, most recently
from
84357b5 to
7b8afe9
Compare
|
pcboy
commented
Jan 2, 2025
| @@ -48,7 +48,7 @@ python3Packages.buildPythonApplication rec { | |||
| pytest-textual-snapshot | |||
| pytestCheckHook | |||
| ] | |||
| ++ lib.optionals (pythonOlder "3.12") [ greenlet ]; | |||
| ++ lib.optionals (pythonOlder "3.14") [ greenlet ]; | |||
There was a problem hiding this comment.
Should be 3.14, otherwise test_greenlet.py fails.
https://github.com/bloomberg/memray/blob/a9237b4b3fc5f83df40bd914a18c7f7a18743270/setup.py#L116
pcboy
commented
Jan 2, 2025
| @@ -58,15 +58,6 @@ python3Packages.buildPythonApplication rec { | |||
| # Import issue | |||
| "test_header_allocator" | |||
| "test_hybrid_stack_of_allocations_inside_ceval" | |||
|
|
|||
| # snapshot-based tests are too fragile | |||
| # see https://github.com/bloomberg/memray/issues/654 | |||
There was a problem hiding this comment.
Ticket is now closed and fixed.
|
|
Thanks @eljamm , I had to bump memray, but now things seem to be working. Only harlequin failing of course, will be fixed after this new textual is merged. |
eljamm
reviewed
Jan 2, 2025
pcboy
force-pushed
the
upgrade-textual-1.0.0
branch
5 times, most recently
from
103cba3 to
79a927e
Compare
|
wegank
added
the
2.status: merge conflict
pcboy
force-pushed
the
upgrade-textual-1.0.0
branch
from
79a927e to
0aa765f
Compare
eljamm
reviewed
Jan 4, 2025
|
Also, I'd like to note that I don't know what the adverse effects on this are on the packages that depend on textual aside from possibly not having any code highlighting. The closest I got to finding a solution is this discourse post which suggests to either package each language individually or re-create the bindings. |
pcboy
force-pushed
the
upgrade-textual-1.0.0
branch
from
0aa765f to
a5d01f7
Compare
13 tasks
eljamm
approved these changes
Jan 4, 2025
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 370103
x86_64-linux
❌ 2 packages failed to build:
- harlequin
- harlequin.dist
✅ 61 packages built:
- browsr
- browsr.dist
- dooit
- dooit-extras
- dooit-extras.dist
- dooit.dist
- frogmouth
- frogmouth.dist
- isponsorblocktv
- isponsorblocktv.dist
- memray
- memray.dist
- mutmut
- mutmut.dist
- oterm
- oterm.dist
- python312Packages.manifestoo
- python312Packages.manifestoo.dist
- python312Packages.pytest-textual-snapshot
- python312Packages.pytest-textual-snapshot.dist
- python312Packages.textual
- python312Packages.textual-dev
- python312Packages.textual-dev.dist
- python312Packages.textual-fastdatatable
- python312Packages.textual-fastdatatable.dist
- python312Packages.textual-slider
- python312Packages.textual-slider.dist
- python312Packages.textual-textarea
- python312Packages.textual-textarea.dist
- python312Packages.textual-universal-directorytree
- python312Packages.textual-universal-directorytree.dist
- python312Packages.textual.dist
- python313Packages.manifestoo
- python313Packages.manifestoo.dist
- python313Packages.pytest-textual-snapshot
- python313Packages.pytest-textual-snapshot.dist
- python313Packages.textual
- python313Packages.textual-dev
- python313Packages.textual-dev.dist
- python313Packages.textual-fastdatatable
- python313Packages.textual-fastdatatable.dist
- python313Packages.textual-slider
- python313Packages.textual-slider.dist
- python313Packages.textual-textarea
- python313Packages.textual-textarea.dist
- python313Packages.textual-universal-directorytree
- python313Packages.textual-universal-directorytree.dist
- python313Packages.textual.dist
- rich-cli
- rich-cli.dist
- smassh
- smassh.dist
- streamcontroller
- tftui
- tftui.dist
- toolong
- toolong.dist
- upiano
- upiano.dist
- wsrepl
- wsrepl.dist
eljamm
added
the
12.approvals: 1
|
eljamm
added
12.approvals: 2
|
@GaetanLepage Is it possible to merge this one so I can fix harlequin in a second MR, or should I fix harlequin directly here so the nixpkgs-review passes? |
Sure, let's do that ! Thanks for the fix. |
FliegendeWurst
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrading textual to latest version 1.0.0
Related: #365766
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)