Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMP] l10n_it_fatturapa_in: Update logic to import e-invoice xml #3513

Conversation

patrickt-oforce
Copy link
Contributor

Update logic to import e-invoice xml, porting logic from PR #3100 and adapting it to v. 14.0

@patrickt-oforce patrickt-oforce force-pushed the 14.0-IMP-l10n_it_fatturapa_in__vat_groups branch 2 times, most recently from 2aaafcd to a08892a Compare August 3, 2023 10:37
@patrickt-oforce patrickt-oforce force-pushed the 14.0-IMP-l10n_it_fatturapa_in__vat_groups branch from a08892a to e7f0558 Compare August 23, 2023 07:35
@matteoopenf
Copy link
Contributor

matteoopenf commented Sep 8, 2023

Ciao @monen17 @SirTakobi questa e' un porting della tua pr a 14, per caso hai qualche suggerimento?
Grazie Mille

@patrickt-oforce patrickt-oforce force-pushed the 14.0-IMP-l10n_it_fatturapa_in__vat_groups branch from c8a8665 to f9b113d Compare September 11, 2023 12:55
@patrickt-oforce
Copy link
Contributor Author

@SirAionTech ho riportato la tua PR per 12.0 ma qui i test falliscono; quando puoi, daresti un'occhiata magari mi sfugge qualcosa

Update logic to import e-invoice xml, porting logic from PR OCA#3100 and adapting it
to v. 14.0
@patrickt-oforce patrickt-oforce force-pushed the 14.0-IMP-l10n_it_fatturapa_in__vat_groups branch from f9b113d to 469c093 Compare September 14, 2023 07:27
Copy link
Contributor

@SirAionTech SirAionTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grazie della PR!
La PR #3100 aveva 4 commit, ognuno con un suo scopo.
Se questa PR deve portare le modifiche di #3100 a 14.0, allora mi aspetterei almeno altrettanti commit, fatti dagli autori originali, più le modifiche necessarie per farli funzionare nella 14.0.

Un modo per fare tutto ciò è portare i 4 commit di #3100 uno per uno con cherry-pick, e verificare di volta in volta che le modifiche introdotte dal commit non rompano i test.
Se c'è qualcosa da correggere lo correggi in un nuovo commit, o se è poca roba nello stesso commit cherry-pickato.

Fare un unico commit con tutto dentro non aiuta il revisore a capire come sono state portate le modifiche, cosa è stato modificato e perché.

Copy link

github-actions bot commented Jun 2, 2024

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 2, 2024
@github-actions github-actions bot closed this Jul 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
14.0 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Importazione fattura elettronica con terzo intermediario in Gruppo IVA
4 participants