Uses finalized block as the freeze threshold #406
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegoximenes
changed the title
diegoximenes
force-pushed
the
ancients_finalized
branch
from
7a15f07 to
321de3a
Compare
diegoximenes
force-pushed
the
ancients_finalized
branch
from
321de3a to
58e535a
Compare
diegoximenes
requested review from
magicxyyz,
ganeshvanahalli and
Tristan-Wilson
tsahee
requested changes
Feb 7, 2025
| @@ -118,24 +117,23 @@ func (f *chainFreezer) readFinalizedNumber(db ethdb.KeyValueReader) uint64 { | |||
| return *number | |||
| } | |||
|
|
|||
| // freezeThreshold returns the threshold for chain freezing. It's determined | |||
| // by formula: max(finality, HEAD-params.FullImmutabilityThreshold). | |||
| // freezeThreshold returns the threshold for chain freezing. | |||
There was a problem hiding this comment.
It seems like the original function is actually good. It's 100% o.k to have a threshold that won't be frozen even if finalized.
Can we remove the change to geth entirely?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to NIT-2585
Uses finalized block as the freeze threshold.
Pulled by OffchainLabs/nitro#2927