Skip to content

Uses finalized block as the freeze threshold #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Uses finalized block as the freeze threshold #406

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5a097fe
Only considers finalized block in freeze threshold computation
diegoximenes Jan 31, 2025
58e535a
Avoids freezing the head of the chain
diegoximenes Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 11 additions & 13 deletions core/rawdb/chain_freezer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@ import (
"github.com/ethereum/go-ethereum/common"
"github.com/ethereum/go-ethereum/ethdb"
"github.com/ethereum/go-ethereum/log"
"github.com/ethereum/go-ethereum/params"
)

const (
Expand Down Expand Up @@ -118,24 +117,23 @@ func (f *chainFreezer) readFinalizedNumber(db ethdb.KeyValueReader) uint64 {
return *number
}

// freezeThreshold returns the threshold for chain freezing. It's determined
// by formula: max(finality, HEAD-params.FullImmutabilityThreshold).
// freezeThreshold returns the threshold for chain freezing.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like the original function is actually good. It's 100% o.k to have a threshold that won't be frozen even if finalized.
Can we remove the change to geth entirely?

func (f *chainFreezer) freezeThreshold(db ethdb.KeyValueReader) (uint64, error) {
var (
head = f.readHeadNumber(db)
final = f.readFinalizedNumber(db)
headLimit uint64
head = f.readHeadNumber(db)
final = f.readFinalizedNumber(db)
)
if head > params.FullImmutabilityThreshold {
headLimit = head - params.FullImmutabilityThreshold
}
if final == 0 && headLimit == 0 {

if final == 0 || (head == final && final == 1) {
return 0, errors.New("freezing threshold is not available")
}
if final > headLimit {
return final, nil

// avoids freezing the head of the chain, since freezing removes the block from the active database
if head == final {
final--
}
return headLimit, nil

return final, nil
}

// freeze is a background thread that periodically checks the blockchain for any
Expand Down