Skip to content

Replace ngOnInit by appropriate signal handling#1330

Merged
dbeuchler merged 25 commits into
devfrom
improve/web-lifecycle
Jul 14, 2026
Merged

Replace ngOnInit by appropriate signal handling#1330
dbeuchler merged 25 commits into
devfrom
improve/web-lifecycle

Conversation

@dbeuchler

@dbeuchler dbeuchler commented Jul 10, 2026

Copy link
Copy Markdown
Member

for #1061

Migrated all BehaviorSubject, Subject, and ReplaySubject patterns to Angular signals to replace ngOnInit by appropriate signal handling with effect. Replaced Observable-based patterns (toSignal, .subscribe()) with direct signal references, computed(), and effect().

  • Replaced all .update(_ => value) calls (where the previous value is unused) with .set(value)
  • Standardized all effect() and untracked() calls to multi-line block.
  • Removed ngOnInit, ngOnDestroy, OnInit, OnDestroy, and Subscription where effects or signals made them unnecessary.

@dbeuchler dbeuchler added this to the Framework 10.x milestone Jul 10, 2026
@dbeuchler dbeuchler self-assigned this Jul 10, 2026
@dbeuchler dbeuchler added the enhancement New feature or request label Jul 10, 2026
@dbeuchler dbeuchler mentioned this pull request Jul 10, 2026
11 tasks
@dbeuchler
dbeuchler force-pushed the improve/web-lifecycle branch from 0415ea7 to ef0afd6 Compare July 10, 2026 12:19
@dbeuchler
dbeuchler requested a review from 1nf0rmagician July 12, 2026 17:57
@dbeuchler
dbeuchler marked this pull request as ready for review July 12, 2026 17:57
Comment thread src/Moryx.Workplans.Web/app/src/app/services/sessions.service.ts
@dbeuchler
dbeuchler merged commit 083de81 into dev Jul 14, 2026
7 checks passed
@dbeuchler
dbeuchler deleted the improve/web-lifecycle branch July 14, 2026 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants