Replace ngOnInit by appropriate signal handling#1330
Merged
Conversation
dbeuchler
force-pushed
the
improve/web-lifecycle
branch
from
July 10, 2026 12:19
0415ea7 to
ef0afd6
Compare
dbeuchler
marked this pull request as ready for review
July 12, 2026 17:57
1nf0rmagician
approved these changes
Jul 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
for #1061
Migrated all
BehaviorSubject,Subject, andReplaySubjectpatterns to Angular signals to replace ngOnInit by appropriate signal handling witheffect. Replaced Observable-based patterns (toSignal,.subscribe()) with direct signal references,computed(), andeffect()..update(_ => value)calls (where the previous value is unused) with.set(value)effect()anduntracked()calls to multi-line block.ngOnInit,ngOnDestroy,OnInit,OnDestroy, andSubscriptionwhere effects or signals made them unnecessary.