Add recoup items/notables #632
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ready to merge on my end |
… for Petrified Blood removal
OrderedSet86
force-pushed
the
recoup-features
branch
from
f85ed04 to
379822e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #353, reapplies PR from broken fork #376.
Description of the problem being solved:
extraPseudoRecoupRecoup Avg.calcsRecoup and Hit Taken Over Time->Net Recovery per Second(later I would like to merge this with the net recovery in the summary sidebar)<type>Mitigation<type>PseudoRecoup-><type>Mitigation<type>Recoup(remove the "pseudo" terminology here - there is nothing "fake" about mitigation recoup)Steps taken to verify a working solution:
Link to a build that showcases this PR:
Two builds.
Chronomancer with 4s recoup base + 25% increased Recoup Speed
Blood Mage with Grasping Wounds + 25% increased Recoup Speed (does not apply to Grasping Wounds but does apply to normal Recoup)
Before screenshot:
Chronomancer build + Wandering Reliquary
Blood mage build + Wandering Reliquary
Breakdown in "avg"
After screenshot:
Chronomancer build + Wandering Reliquary
Blood mage build + Wandering Reliquary
Breakdown in "avg"
