Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

16 Ensure CI execution of Niwot site #17

Merged
merged 4 commits into from
Aug 16, 2024
Merged

16 Ensure CI execution of Niwot site #17

merged 4 commits into from
Aug 16, 2024

Conversation

Alomir
Copy link
Contributor

@Alomir Alomir commented Aug 16, 2024

Adds an existence check for the test output

@Alomir Alomir requested a review from robkooper August 16, 2024 16:46
Copy link
Member

@robkooper robkooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The action seemed to fail on windows, which seems to be most of the work adding this module.

@Alomir
Copy link
Contributor Author

Alomir commented Aug 16, 2024

The action seemed to fail on windows, which seems to be most of the work adding this module.

Yep, apologies in being too fast on requesting a review - looking for cross-platform solution

@robkooper
Copy link
Member

problem with the rm -f vs rm is that if the files does not exist it will fail with just the rm command. Seeing that it runs, I can only assume the file will exist.

@Alomir
Copy link
Contributor Author

Alomir commented Aug 16, 2024

@robkooper Indeed, I'm not very excited by just rm - but at least in this case, all we want if the file to not exist when the test is run, so if it already doesn't, that's fine.

I'm hoping this is a stop-gap measure before we put a better regression test system in place.

@dlebauer dlebauer merged commit 5c9bdc0 into master Aug 16, 2024
4 checks passed
dlebauer added a commit that referenced this pull request Aug 19, 2024
While implementing & reviewing #17 and #18 it became clear that supporting Windows builds would require a lot of exceptions. Given that Windows Subsystem for Linux provides a viable option for Windows users this PR proposes removing support for windows builds.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants