Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ORG79 Add irrigation event support #26

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Alomir
Copy link
Contributor

@Alomir Alomir commented Feb 7, 2025

No description provided.

@Alomir Alomir changed the title ORG79 Adds irrigation event support ORG79 Add irrigation event support Feb 7, 2025
@dlebauer
Copy link
Member

dlebauer commented Feb 7, 2025

how do we want to test this? What should 'success' look like?

I think the following approach covers key aspects of the feature.

After reading an irrigation event:

  1. Event is recognized and logged
    • irrig <0 --> error
    • printevent logs event
  2. Event has intended impact
    • soilWater increases
    • if canopy irrigation:
      • immedEvap increases

It is possible that this could be done in two timesteps, one before and one the event.

This isn't comprehensive but it exceeds the 'test any feature you want to persist' expectation in the PEcAn project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants