Repository navigation
docs: Flesh out organic amendment carbon quality partition equations … - #407
Open
coder-Yash886 wants to merge 2 commits into
Open
coder-Yash886 wants to merge 2 commits into
coder-Yash886 wants to merge 2 commits into
Conversation
coder-Yash886
requested review from
Alomir,
dlebauer,
mdietze and
mswilburn
as code owners
October 16, 2026 17:46
Author
|
@dlebauer @divine7022 @Alomir Please Review the Pr When you have the free time |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #396 (Phase 1: Documentation & Mathematical Specification).
Following the discussion in #396, this PR outlines the proposed equations and parameters in model-structure.md and parameters.md for adding an organic amendment carbon quality partition to SIPNET before introducing code changes.
Currently, all amendment organic C enters the litter pool as labile material when
LITTER_POOL = 1, causingfracLitterRespiredto rail against its bound for mature composts. We propose partitioning amendment C at entry into a pre-stabilized fraction directly entering soil, and a labile fraction entering litter.Proposed Equations
Proposed Parameter (
docs/parameters.md)fracOrgCStableLITTER_POOL = 1