-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added states (regions) in pe.xml according to ISO 3166-2. #22
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can see that not all the regions that appear here: https://www.iso.org/obp/ui/#iso:code:3166:PE were added to this PR. Is it on purpose?
I noticed that some of them appear two times on the website, but I think some are still missing (e.g. Wanuku).
Could you double-check, please? 😇
<state name="Arequipa" iso_code="ARE" country="PE" zone="South America" /> | ||
<state name="Ayacucho" iso_code="AYA" country="PE" zone="South America" /> | ||
<state name="Cajamarca" iso_code="CAJ" country="PE" zone="South America" /> | ||
<state name="Callao" iso_code="CAL" country="PE" zone="South America" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
<state name="Callao" iso_code="CAL" country="PE" zone="South America" /> | |
<state name="El Callao" iso_code="CAL" country="PE" zone="South America" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for reviewing my PR. I updated correction "Callao" to "El Callao" (as it is stated in the ISO.org website).
A further investigation, the official country website (https://www.peru.gob.pe/directorio/pep_directorio_poderes.asp?cod_poder=7) shows "Callao" without any pronouns ("El"), but it preserves the pronoun "La" in "La Libertad".
So I went to Perú's Constitution (https://www.congreso.gob.pe/Docs/constitucion/constitucion/Constitucion-politica-Peru.pdf) in its "duodécima" article, which states
Duodécima. La organización política departamental de la República comprende los departamentos siguientes:
Amazonas, Ancash, Apurímac, Arequipa, Ayacucho, Cajamarca, Cusco, Huancavelica, Huánuco, Ica, Junín, La Libertad, Lambayeque, Lima, Loreto, Madre de Dios, Moquegua, Pasco, Piura, Puno, San Martín, Tacna, Tumbes, Ucayali; y la Provincia Constitucional del Callao.
So all names matches the ones at ISO website, except for "El Callao" which is called "Provincia Constitucional del Callao".
So it doesn´t seems the government itself or its population uses the formal and larger name. I believe if we stick with the less proper name "Callao" or "El Callao" with its pronoun, we will be fine.
PS. I noticed after I commited your suggested change, "El Callao" is not in proper line following the alphabetical order. I wonder if I should force update the patch. Although not that it matters, it doesn´t affect the final result (PS will order them alphabetically when showing them to the user), it is just a personal thing on the way I read the xml.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @rickygzz, thanks for this explanation. @eternoendless is a Spanish native speaker, so maybe he can help you decide whether we should use "El Callao" or "Callao".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know what the custom in Peru is for this region, but I would personally not use the pronoun. Since the capital city is called "Callao" I think it's a safe bet to call the province just Callao as well.
The iso website shows the name for each state (region) in 3 different languages for this country. You could click on the language column to order names by its languages. I added the Spanish variation as the most widely used language in Peru (the other 2 languages are indigenous or native ones) |
Changed "Callao" to "El Callao" Co-authored-by: Julie Varisellaz <[email protected]>
Just to expand my explanation on https://www.iso.org/obp/ui/#iso:code:3166:PE showing the names in 3 different languages... In the case of Wanuku (ISO code HUC) seems to be the name in Aymara and Quechua languages ("aym" and "que" language codes), while in Spanish ("spa" language code) it is called Huánuco. As a Spanish native speaker, if I try to pronounce Wanuku kind of resembles Huánuco. And we should stick with Spanish, as it is the official language in the Perú's Constitution (https://www.congreso.gob.pe/Docs/constitucion/constitucion/Constitucion-politica-Peru.pdf )
Also the Constitution states
|
Added <states> tag according to ISO 3166-2 (https://www.iso.org/obp/ui/#iso:code:3166:PE).