Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added states (regions) in pe.xml according to ISO 3166-2. #22

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Added states (regions) in pe.xml according to ISO 3166-2. #22

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3f41a79
Added states (regions) in pe.xml according to ISO 3166-2.
rickygzz Dec 23, 2021
bcf0cfc
Update pe.xml
rickygzz Dec 26, 2021
d102946
Follow Pablo's suggestion and remove "El"
kpodemski Jul 18, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 27 additions & 0 deletions pe.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,33 @@
<tax id="53" name="Impuesto General a la Ventas" rate="16.000"/>
<tax id="54" name="Impuesto de Promocion Municipal" rate="2.000"/>
</taxes>
<states>
<state name="Amazonas" iso_code="AMA" country="PE" zone="South America" />
<state name="Ancash" iso_code="ANC" country="PE" zone="South America" />
<state name="Apurímac" iso_code="APU" country="PE" zone="South America" />
<state name="Arequipa" iso_code="ARE" country="PE" zone="South America" />
<state name="Ayacucho" iso_code="AYA" country="PE" zone="South America" />
<state name="Cajamarca" iso_code="CAJ" country="PE" zone="South America" />
<state name="Callao" iso_code="CAL" country="PE" zone="South America" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<state name="Callao" iso_code="CAL" country="PE" zone="South America" />
<state name="El Callao" iso_code="CAL" country="PE" zone="South America" />

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for reviewing my PR. I updated correction "Callao" to "El Callao" (as it is stated in the ISO.org website).

A further investigation, the official country website (https://www.peru.gob.pe/directorio/pep_directorio_poderes.asp?cod_poder=7) shows "Callao" without any pronouns ("El"), but it preserves the pronoun "La" in "La Libertad".

So I went to Perú's Constitution (https://www.congreso.gob.pe/Docs/constitucion/constitucion/Constitucion-politica-Peru.pdf) in its "duodécima" article, which states

Duodécima. La organización política departamental de la República comprende los departamentos siguientes:
Amazonas, Ancash, Apurímac, Arequipa, Ayacucho, Cajamarca, Cusco, Huancavelica, Huánuco, Ica, Junín, La Libertad, Lambayeque, Lima, Loreto, Madre de Dios, Moquegua, Pasco, Piura, Puno, San Martín, Tacna, Tumbes, Ucayali; y la Provincia Constitucional del Callao.

So all names matches the ones at ISO website, except for "El Callao" which is called "Provincia Constitucional del Callao".

So it doesn´t seems the government itself or its population uses the formal and larger name. I believe if we stick with the less proper name "Callao" or "El Callao" with its pronoun, we will be fine.

PS. I noticed after I commited your suggested change, "El Callao" is not in proper line following the alphabetical order. I wonder if I should force update the patch. Although not that it matters, it doesn´t affect the final result (PS will order them alphabetically when showing them to the user), it is just a personal thing on the way I read the xml.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @rickygzz, thanks for this explanation. @eternoendless is a Spanish native speaker, so maybe he can help you decide whether we should use "El Callao" or "Callao".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know what the custom in Peru is for this region, but I would personally not use the pronoun. Since the capital city is called "Callao" I think it's a safe bet to call the province just Callao as well.

<state name="Cusco" iso_code="CUS" country="PE" zone="South America" />
<state name="Huancavelica" iso_code="HUV" country="PE" zone="South America" />
<state name="Huánuco" iso_code="HUC" country="PE" zone="South America" />
<state name="Ica" iso_code="ICA" country="PE" zone="South America" />
<state name="Junín" iso_code="JUN" country="PE" zone="South America" />
<state name="La Libertad" iso_code="LAL" country="PE" zone="South America" />
<state name="Lambayeque" iso_code="LAM" country="PE" zone="South America" />
<state name="Lima" iso_code="LIM" country="PE" zone="South America" />
<state name="Loreto" iso_code="LOR" country="PE" zone="South America" />
<state name="Madre de Dios" iso_code="MDD" country="PE" zone="South America" />
<state name="Moquegua" iso_code="MOQ" country="PE" zone="South America" />
<state name="Pasco" iso_code="PAS" country="PE" zone="South America" />
<state name="Piura" iso_code="PIU" country="PE" zone="South America" />
<state name="Puno" iso_code="PUN" country="PE" zone="South America" />
<state name="San Martín" iso_code="SAM" country="PE" zone="South America" />
<state name="Tacna" iso_code="TAC" country="PE" zone="South America" />
<state name="Tumbes" iso_code="TUM" country="PE" zone="South America" />
<state name="Ucayali" iso_code="UCA" country="PE" zone="South America" />
</states>
<units>
<unit type="weight" value="kg"/>
<unit type="volume" value="L"/>
Expand Down