Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

💥 Artifact Assetのトリガーのマクロ化 #1621

Open
wants to merge 49 commits into
base: master
Choose a base branch
from
Open

💥 Artifact Assetのトリガーのマクロ化 #1621

wants to merge 49 commits into from

Conversation

haiiro2gou
Copy link
Member

@haiiro2gou haiiro2gou commented Nov 4, 2024 •
edited
Loading

仕様

  • ♻️ api:artifact/** の処理の改善
    • 特筆すべきことはないはず
  • 💥 トリガーのマクロ化
    • トリガー処理を MobAsset や ObjectAsset 同様 alias をマクロで呼び出す形式に変更
    • それに際して check 及び use 処理も内部化
    • そのため神器内のトリガー処理での前処理が困難になっている リセット用後処理の追加により解決
    • use のフラグの一つである IgnoreItemUpdate を神器内のデータに移動
    • 各トリガーについて同様の呼び出し処理を行っているため core 内のファイル数が非常に多い (改善案募集中)
  • ✨ サブトリガー機能の実装
    • 条件を問わず発動させたい処理を明示できる
    • ただし、信仰と最大重複数 (PartsMax) の制約を受ける
  • 🐛 装備時補正の内部化
    • 装備時のステータス補正 (Modifiers) を core 側で処理するように
    • フルセット効果 (EquipID) を Effect Asset で処理するように
    • 改宗時に補正が更新されない問題の解決
    • 装備時処理はサブトリガーでのみ処理可能

Fixed #1026
Fixed #1513

Related #1440

Rework #1489

@haiiro2gou
Copy link
Member Author

haiiro2gou commented Nov 4, 2024 •
edited
Loading

ToDo: Asset用のメモ・テンプレート

@haiiro2gou haiiro2gou changed the title 💥 Artifact Assetのリワーク 💥 Artifact Assetのトリガーをマクロによって実行できるように Nov 4, 2024
@haiiro2gou haiiro2gou changed the title 💥 Artifact Assetのトリガーをマクロによって実行できるように 💥 Artifact Assetのトリガーのマクロ化 Nov 4, 2024
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch from 1da80df to 7ab0410 Compare November 17, 2024 14:50
@haiiro2gou haiiro2gou marked this pull request as ready for review November 17, 2024 14:51
@haiiro2gou haiiro2gou requested a review from ChenCMD as a code owner November 17, 2024 14:51
@haiiro2gou
Copy link
Member Author

それぞれのTriggerに条件を登録できるようにすれば
こんな過剰量のトリガーファイルを生み出さなくてよくなるのかもしれない…

@haiiro2gou haiiro2gou mentioned this pull request Nov 22, 2024
Open
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch 7 times, most recently from 03dc669 to 6f4011a Compare November 24, 2024 12:26
@haiiro2gou haiiro2gou mentioned this pull request Nov 29, 2024
Closed
13 tasks
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch 5 times, most recently from 42aa265 to af825de Compare December 4, 2024 08:44
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch from 6c923b3 to 78baea1 Compare December 17, 2024 04:24
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch from 379a200 to 8d749b4 Compare January 17, 2025 08:16
@haiiro2gou haiiro2gou mentioned this pull request Jan 25, 2025
Open
@haiiro2gou haiiro2gou force-pushed the rework/haiiro_artifact-trigger branch from b231da6 to 7e60cc2 Compare January 26, 2025 19:25
@haiiro2gou haiiro2gou mentioned this pull request Jan 29, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenCMD ChenCMD Awaiting requested review from ChenCMD ChenCMD is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

神器のディレクトリ構造を一新する 攻撃時にMPが回復するようにする
1 participant
@haiiro2gou