Simplify build.rs #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All RIOT versions that did not have the expected values there have long been unsupported.
This removes all dependencies on `link=` exported DEP_RIOT_SYS_ variables infavor of parsing riotbuild.h.
|
With the latest additions this also does away with (long inaccurate) MSRV information. |
chrysn
force-pushed
the
simplify-build
branch
from
7dcc8ee to
6886a10
Compare
This was referenced Jan 31, 2024
chrysn
added a commit
to RIOT-OS/rust-riot-sys
that referenced
this pull request
Jan 31, 2024
The CC/CFLAGS are thus not exported any more (riot-wrappers doesn't need them since [79]), and the modules list is not neede any more because it was only taken in to be forwarded. [79]: RIOT-OS/rust-riot-wrappers#79
|
Merged as this is useful around RIOT-OS/RIOT#20088, and would break RIOT-OS/RIOT#20319 if done later. |
chrysn
added a commit
that referenced
this pull request
Oct 17, 2024
While [PR20900] provides a compatibility .hdr accessor through a union, that trick is not available through bindgen or c2rust, which all introduce a dummy-named field for the anonymous union. Instead, we follow the path set out by [PR79] and introspect the source file. [PR20900]: RIOT-OS/RIOT#20900 [PR79]: #79 Co-Authored-By: Marian Buschsieweke <[email protected]>
chrysn
added a commit
that referenced
this pull request
Oct 17, 2024
While [PR20900] provides a compatibility .hdr accessor through a union, that trick is not available through bindgen or c2rust, which all introduce a dummy-named field for the anonymous union. Instead, we follow the path set out by [PR79] and introspect the source file. [PR20900]: RIOT-OS/RIOT#20900 [PR79]: #79 Co-Authored-By: Marian Buschsieweke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change in this PR is that instead of relying on riot-sys to export various pre-processed data, we just find riotbuild.h (which conveniently is an exported environment variable) and dig right into that.
This will allow riot-sys to no longer
links="riot-sys", and untangles the build steps. It may also speed things up, because now riot-wrappers will rebuild precisely when riotbuild.h changes.On the downside, this has no provisions for further code dependent markers, which have in the past helped us across C API changes. A possible step forward on that is to just look at the relevant file in RIOTBASE to determine whether it contains a marker string -- also a way more direct method.