Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing taxonomy information from rnc_accessions #162

Closed
wants to merge 17 commits into from
Closed

Conversation

afg1
Copy link
Contributor

@afg1 afg1 commented Nov 11, 2022

Working in the dev database until I get everything running smoothly. This is a place to look at what is changing, the main tracking is in #161

afg1 and others added 17 commits October 28, 2022 12:24
Update master with changes from dev for Release 21
Bumps [regex](https://github.com/rust-lang/regex) from 1.4.3 to 1.5.5.
- [Release notes](https://github.com/rust-lang/regex/releases)
- [Changelog](https://github.com/rust-lang/regex/blob/master/CHANGELOG.md)
- [Commits](rust-lang/regex@1.4.3...1.5.5)

---
updated-dependencies:
- dependency-name: regex
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [py](https://github.com/pytest-dev/py) from 1.9.0 to 1.11.0.
- [Release notes](https://github.com/pytest-dev/py/releases)
- [Changelog](https://github.com/pytest-dev/py/blob/master/CHANGELOG.rst)
- [Commits](pytest-dev/py@1.9.0...1.11.0)

---
updated-dependencies:
- dependency-name: py
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [joblib](https://github.com/joblib/joblib) from 1.0.1 to 1.2.0.
- [Release notes](https://github.com/joblib/joblib/releases)
- [Changelog](https://github.com/joblib/joblib/blob/master/CHANGES.rst)
- [Commits](joblib/joblib@1.0.1...1.2.0)

---
updated-dependencies:
- dependency-name: joblib
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Any pull request that gets merged with a commit message starting 'Release:' will trigger automatic version tagging
Adds a new branch in the action so it should build, but disables the push and conversion in this branch
This will need to be done properly in poetry, but that's another headache
The build appears to mostly run ok, so this will allow us to test it
In the hope it will compile now
Haven't got it to build yet
@blakesweeney
Copy link
Member

I think this is handled by #179 and can be closed. If so please close this and delete the branch @afg1 .

@afg1
Copy link
Contributor Author

afg1 commented Feb 5, 2024

I think you're right, but this maybe goes further in that we originally intended to enforce a foreign key constraint on xref.taxid to rnc_taxonomy. AFAIK that was tested in the DEV database, but I never moved it across to PRO. None of that needs changes in the pipeline though, so we can close this and probably issue #161 as well

@afg1 afg1 closed this Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants