-
Notifications
You must be signed in to change notification settings - Fork 24
feat: add new summary statistics #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Thanks for using the semantic commit style in the PR header! I use that commit style because it makes the changelog easier to skim [see the 0.5 release changelog for an example])
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't carefully reviewed the expected output files yet.
Co-authored-by: Tristan F.-R. <[email protected]>
Documentation build overview
Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have one final small question, and then this is essentially ready to merge.
The discussion of how these summary statistics assume an undirected graph and convert directed edges does point out that we need to start writing docs. That can happen separately.
Adding in new statistics mentioned in #349.