Skip to content

Conversation

@ntalluri
Copy link
Collaborator

@ntalluri ntalluri commented Aug 7, 2025

Adding in new statistics mentioned in #349.

@ntalluri ntalluri added analysis Analysis of PRA outputs needed for benchmarking Priority PRs needed for the benchmarking paper labels Aug 7, 2025
Copy link
Collaborator

@tristan-f-r tristan-f-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Thanks for using the semantic commit style in the PR header! I use that commit style because it makes the changelog easier to skim [see the 0.5 release changelog for an example])

@tristan-f-r tristan-f-r changed the title refactor: Adding new summary statistics feat: add new summary statistics Aug 8, 2025
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't carefully reviewed the expected output files yet.

@read-the-docs-community
Copy link

read-the-docs-community bot commented Aug 11, 2025

Documentation build overview

📚 spras | 🛠️ Build #29239897 | 📁 Comparing e181563 against latest (647f4a1)


🔍 Preview build

Show files changed (2 files in total): 📝 2 modified | ➕ 0 added | ➖ 0 deleted
File Status
fordevs/spras.html 📝 modified
prms/oi1.html 📝 modified

@ntalluri ntalluri requested a review from agitter August 11, 2025 16:34
Copy link
Collaborator

@agitter agitter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one final small question, and then this is essentially ready to merge.

The discussion of how these summary statistics assume an undirected graph and convert directed edges does point out that we need to start writing docs. That can happen separately.

@ntalluri ntalluri requested a review from agitter August 18, 2025 16:08
@agitter agitter merged commit 6c73209 into Reed-CompBio:main Aug 23, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

analysis Analysis of PRA outputs needed for benchmarking Priority PRs needed for the benchmarking paper

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants