Free Kick / Penalty / Kickoff #2200

sanatd33 · 2024-02-28T02:08:31Z

Description

Writes free kick, kickoff, penalty code

Associated / Resolved Issue

Resolves https://app.clickup.com/t/86azbvek6

Key Files to Review

robot_factory_position.cpp

Review Checklist

Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
Remove extra print statements: Any print statements used for debugging should be removed
Tag reviewers: Tag some people for review and ping them on Slack

sid-parikh · 2024-02-28T22:48:01Z

@sanatd33 I can't get this to work on my computer. Also GH failed to build for some reason.

sid-parikh

not sure that it works right now

sid-parikh

It still isn't building on GH.

soccer/src/soccer/strategy/agent/agent_action_client.cpp

…e alive_robots_. Modified type of alive_robots_ almost everywhere to be the std::array<bool, kNumShells> rather than the std::vector<int>

… the new array parameter, made code cleaner for loop in robot_factory_position

…ategy/alive_robots) for consistency

automated style fixes Co-authored-by: sanatd33 <[email protected]>

… that might work

…is in a legal position. Next step is to add it to the cmake file so that we can test it, and then be able to switch to the position in robot_factory_position

sid-parikh · 2024-03-13T06:41:10Z

see #2236 for an updated version of this PR

github-actions bot mentioned this pull request Feb 28, 2024

Fix Code Style On kicker-picker #2201

Merged

sid-parikh requested changes Feb 28, 2024

View reviewed changes

github-actions bot mentioned this pull request Feb 28, 2024

Fix Code Style On kicker-picker #2203

Merged

sid-parikh requested changes Mar 1, 2024

View reviewed changes

soccer/src/soccer/strategy/agent/agent_action_client.cpp Outdated Show resolved Hide resolved

sanatd33 force-pushed the kicker-picker branch from cc7f782 to 6758f16 Compare March 6, 2024 01:03

github-actions bot mentioned this pull request Mar 6, 2024

Fix Code Style On kicker-picker #2211

Merged

sanatd33 requested a review from sid-parikh March 6, 2024 01:54

Shourik and others added 22 commits March 6, 2024 19:01

modified code in robot_factory_position and a few other classes to us…

7d14611

…e alive_robots_. Modified type of alive_robots_ almost everywhere to be the std::array<bool, kNumShells> rather than the std::vector<int>

modified code in update_alive_robots in position to use the data from…

32e194c

… the new array parameter, made code cleaner for loop in robot_factory_position

Apply suggestions from code review

748aa37

typo & pretty-lines

ef2d465

Add topic name constant for strategy/alive_robots

b1d2718

Publish robots 0-6 as alive in sim_radio

8a8a554

Use global topic name declaration in agent_action_client

d162471

Change topic name in radio to use the global costant declaration (str…

de004c7

…ategy/alive_robots) for consistency

Fix style formatting

8178d7b

combine both branches; why four offense??

3f0c927

fix alive_robots and goalie_id propagation

1f8382f

Made the requests a queue and added code to determine kicker

ee8eb82

Working on implemetning free kick

d234e31

reformat

e23cff3

clang-tidy

47bb66f

change name; cleanup; use deque (queue not iterable)

53ac7b3

use max

4714167

free kick works basic. need state machine

a94f28f

Added State machine and implemented free kick/kickoff

3385d90

Fix Code Style On kicker-picker (#2201)

492a0ee

automated style fixes Co-authored-by: sanatd33 <[email protected]>

Fixed compile error in theory

4ffa80e

Fix Code Style On kicker-picker (#2211)

f56abf3

automated style fixes Co-authored-by: sanatd33 <[email protected]>

sanatd33 and others added 2 commits March 6, 2024 17:01

ok compile errors gone now

5c1d205

rebase with position-assignment

d944e4f

sid-parikh force-pushed the kicker-picker branch from ec08690 to d944e4f Compare March 6, 2024 22:13

github-actions bot mentioned this pull request Mar 6, 2024

Fix Code Style On kicker-picker #2217

Closed

sid-parikh added 6 commits March 6, 2024 17:25

expect referee to be physically on localhost

873803d

use RTTI to switch classes

aa5a0cf

more RTTI

4afc316

reformat

d639e3a

WIP VERY WIP

dd09832

WIP

4faf8ab

sid-parikh marked this pull request as draft March 10, 2024 18:54

petergarud and others added 10 commits March 11, 2024 00:43

goalie pk skeleton

c3de1fa

added penalty_player stuff

c38789e

Cleaned up code so it compiles, added a smart idlewith a path planner…

c73fc84

… that might work

Made a slight modification to smart idle

3d840f1

made SmartIdle get away from the ball in penalty position so that it …

0794d89

…is in a legal position. Next step is to add it to the cmake file so that we can test it, and then be able to switch to the position in robot_factory_position

finished basic functionality for penalty player

4b8fe1d

fixed a bug with position reassignment in robot_factory_position

7787dd0

update state machine

57ecbb5

Merge remote-tracking branch 'origin/pk' into kicker-picker

51636b7

fix a few bugs; getting there

6b08314

sid-parikh mentioned this pull request Mar 13, 2024

Alive Robots in robot_factory_position #2212

Closed

sid-parikh closed this Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Free Kick / Penalty / Kickoff #2200

Free Kick / Penalty / Kickoff #2200

sanatd33 commented Feb 28, 2024

sid-parikh commented Feb 28, 2024

sid-parikh left a comment

sid-parikh left a comment

sid-parikh commented Mar 13, 2024

Free Kick / Penalty / Kickoff #2200

Free Kick / Penalty / Kickoff #2200

Conversation

sanatd33 commented Feb 28, 2024

Description

Associated / Resolved Issue

Key Files to Review

Review Checklist

sid-parikh commented Feb 28, 2024

sid-parikh left a comment

Choose a reason for hiding this comment

sid-parikh left a comment

Choose a reason for hiding this comment

sid-parikh commented Mar 13, 2024