Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offense fsm skel #2204

Merged
merged 34 commits into from
Mar 1, 2024
Merged

Offense fsm skel #2204

merged 34 commits into from
Mar 1, 2024

Conversation

jacksherling
Copy link
Contributor

Description

Rewrite of offensive state machine.

Associated / Resolved Issue

Resolves ClickUp card

Design Documents

Link

Steps to Test

Test Case 1: Stealing

  1. Move ball away from robots.

Expected result: If one of our robots is closest to the ball, it will fetch it

Test Case 1: Passing

  1. Let robot establish possession (e.g. after stealing)
  2. Place enemy robot in front of robot to block shot

Expected result: Robot should pass to another robot

Test Case 1: Shooting

  1. Let robot establish possession (e.g. after stealing)
  2. Ensure no enemy robots are in the way

Expected result: Robot should shoot on enemy goal

Key Files to Review

  • offense.cpp/hpp
  • position.cpp

Review Checklist

  • Docstrings: All methods and classes should have the file appropriate docstrings which follow the guidelines in the "Contributing" page of our docs.
  • Remove extra print statements: Any print statements used for debugging should be removed
  • Tag reviewers: Tag some people for review and ping them on Slack

Copy link
Contributor

@sid-parikh sid-parikh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm approving, but there are comments that ought to be addressed eventually. If we can get to them before Sunday, then push them into this PR. If not, I'll add them to future tasks. Either way, we need this merged before start of meeting Sunday to assign new tasks that build on this.

@sid-parikh sid-parikh merged commit 277dc42 into ros2 Mar 1, 2024
2 checks passed
@sid-parikh sid-parikh deleted the offense-fsm-skel branch March 1, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants