Feature/friends subsystem #32
Conversation
…ever see the names being printed. Tried to fix it by adding more attributes and updating the tuple, which should work but the actual display name is never being returned. Have to figure that out later.
…receiving the names of queried people now though.
…me displayed of the user. Turns out there was a problem in OnlineSubsystemEpicTypes.h that was using the product user id instead of the account user id.
…ole purpose of demonstrating the bug fix for this issue.
…hould be mergable now.
…vents working for when friends are added and when presence changes for friends (offline/online).
…y presence method. Currently not done though because we need to detect when the query and the presence info is done.
…dEpic type as well.
…e delegate properly - debugger crashes there.
…be able to get when presence has changed - and right now, it crashes - so redoing that function.
…o do presence + friends will probably have to change at a high level.
| @@ -5,6 +5,7 @@ | |||
| #include "OnlineSubsystemUtils.h" | |||
| #include "OnlineSubsystemEpicTypes.h" | |||
| #include "Utilities.h" | |||
| #include "Private/Utilities.h" | |||
There was a problem hiding this comment.
Please check if you and your team have configured the build process correctly. You shouldn't need the Private part of the include path.
…ibing to updates gets presence called x amount of times, which may be a problem with subscribing to listen to each user's events.
… I had done the past couple of weeks. May re-open the bug query issue to refix some things.
|
Tested presence and friends and they both work now where you can receive updates of when friends go online/offline. I imagine this will also work with sessions, but not tested yet since the Session Interface still seems buggy. I will do some further cleanup before this is suitable for review. |
|
Technically this fixes bugs in the user + presence interfaces too, but I don't know how you want me to address that, whether it is in this issue or in a different one. |
|
If it's not too much work better open a new PR, makes for better changelogs (which I automatically generate with GitHub Changelog Generator). otherwise leave this here. |
…ched, which means we don't have to check to do a query unnecessarily.
…er faster than data can be received for some reason.
|
Ready for review again. |
| } | ||
| } | ||
| //TODO - I don't know if this is right to just access 0 but I can't get the num anywhere else - maybe we loop through all local players? | ||
| TSharedPtr<FUniqueNetId const> localUser = subsystem->GetIdentityInterface()->GetUniquePlayerId(0); |
There was a problem hiding this comment.
The identity interface has the FPlatformUserId GetPlatformUserIdFromUniqueNetId(const FUniqueNetId&) const; method you can use. Any FPlatformUserId is just a TypeDef'd int32
There was a problem hiding this comment.
Ok - problem with this though. I don't have access to the local user FUniqueNetId
There was a problem hiding this comment.
I just looked into the OSS code to see what they actually want with this method. It's bugged as it is missing a parameter, which tells which user id's to query presence for. So going by the comments in Epics code and the method header, User is the aforementioned local user and the missing UserIds parameter would be the users to query presence for.
Since we're missing a parameter we have to assume that a call to this method intends to query all available presence information.
There was a problem hiding this comment.
Yes, we don't have this. You want to be able to use this for any user that you want to get information about. So you have to pass in the remote user as the parameter. A hack fix I can do is just loop through all the local players - similar to what is in the GetPlatformUserId function, and just query loop through valid ones using GetUniquePlayerId.
Source/OnlineSubsystemEpic/Private/OnlineFriendsInterfaceEpic.h
Outdated
Show resolved
Hide resolved
| }; | ||
|
|
||
| /**Mmap of local user idx to friends */ | ||
| TMap<int32, FEpicFriendsList> FriendsLists; |
There was a problem hiding this comment.
Why? SteamFriendsSubsystem does it like this and I don't see any problems with it. I only need one type - the TArray of shared refs - the struct is there for readability.
There was a problem hiding this comment.
With TMultiMap You can write: TMultiMap<int32, TSharedRef<FOnlineFriendEpic>> FriendsLists; and then use methods like MultiFind to get the values for a key. It does the same thing you do, but without the need for an extra struct or nested TArray. It also should be slightly faster and is more space efficient and gives us the option (if we really need it) to add custom key and value functions for equality.
It's not totally necessary, but in my eyes it simply looks cleaner, as this is the intended use for a MultiMap.
There was a problem hiding this comment.
Hm, maybe I can add it later as an enhancement. Would like to see what other issues people experience or want added. For instance, one of the enhancements I was considering adding was a way to just pass in "Online" or "Offline" and then filter out all of those friends that have offline or online. This is something that could only be done in EAS since no other service provides this, but I didn't deem it necessary for now. I could definitely use a MultiMap for then
MikhailSorokin
force-pushed
the
Feature/FriendsSubsystem
branch
from
e677c24 to
098c410
Compare
MikhailSorokin
changed the title
…ing properly. Here were the changes: (1) - made some updates to presence in order to cache information in the query presence call and not duplicate information and (2) - some changes in friend interface that will allow IsFriend and GetFriend to return properly as a hack fix since I don't understand shared references and why data would be garbage collected over time.
|
Updated again with latest comment explaining the changes. It now works better - without duplication of some information in presence. |
|
I also tested by updating the presence on and off on accounts and display name + presence switching worked on an epic account I had with 6 friends. |
Pull Request Template
Checklist:
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change. Any change needs to be discussed before proceeding.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
A draft of what the friends subsystem will look like. Queries now work and I've tested the calls every 3 seconds, so its working fine. However, I want to subscribe the friends to presence and friend status changes, i.e. - when friend presence changes - update the list and when new friends are added, update the list, etc.
So, you can take a look and add comments as I finish up that part of the friends interface.