Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/friends subsystem #32

Open
wants to merge 37 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 19 commits
Commits
Show all changes
37 commits
Select commit Hold shift + click to select a range
549dbd7
Compiled code with fixed identity and user interface calls. Will need…
Jul 8, 2020
fc20ef4
Found a bug where the query was never being triggered, so one could n…
abrarsaleh Jul 8, 2020
bfcd213
Queries now complete properly - first problem fix. Am having trouble …
abrarsaleh Jul 8, 2020
339661b
Fixed the final error in user info queries - which was getting the na…
abrarsaleh Jul 9, 2020
f636990
Commented out presence as it throws a compile error.
abrarsaleh Jul 9, 2020
4b116f0
Did cleanup of code and removed friends interface from here for the s…
abrarsaleh Jul 9, 2020
536ff10
Some refactoring changes with friend invite stuff.
MikhailSorokin Jul 9, 2020
d07e70a
Addressed all commments for PR besides merge conflict.
MikhailSorokin Jul 10, 2020
ea3b31d
Addressed merge conflict and changed back to 'ToProdcutUserId' lol. S…
MikhailSorokin Jul 10, 2020
3e28ba8
Friend queries now work and refactored. NEXT STEP: Get subscription e…
MikhailSorokin Jul 10, 2020
1655913
Done how I think presence should work and should fix a subscribe quer…
MikhailSorokin Jul 10, 2020
38cdd77
Fix file spelling error
Ruhrpottpatriot Jul 10, 2020
1f4f76a
Updated with latest master. Added in several fixes to the FUniqueNetI…
MikhailSorokin Jul 11, 2020
5879bb8
Merge branch 'Bug/UserInfoQuery' into Feature/FriendsSubsystem
MikhailSorokin Jul 11, 2020
b9aa1b0
FIx minor style things
Ruhrpottpatriot Jul 11, 2020
2bc8ee7
Issue fixed with null-termination.
MikhailSorokin Jul 11, 2020
0dc6dee
QueryPresence is now returning a success call but I cannot execute th…
MikhailSorokin Jul 11, 2020
9a51150
Quering presence now works - tested with friends. However, I want to …
MikhailSorokin Jul 11, 2020
b2c4954
Presence + friend for subscription events no longer crashes but way t…
MikhailSorokin Jul 11, 2020
2371fa7
Complete friends and presence implementation. For some reason, subscr…
abrarsaleh Jul 20, 2020
fe85150
Merged with updated master. This now incorporates all changes of what…
abrarsaleh Jul 20, 2020
ce56b12
Compile error fix.
abrarsaleh Jul 20, 2020
131bca2
User query info complete fix.
MikhailSorokin Jul 27, 2020
d88b381
Small formatting fixes.
MikhailSorokin Jul 27, 2020
3f96cd6
Merging with latest master.
MikhailSorokin Jul 27, 2020
ab2705c
Removal of finished query and check if we have information already ca…
MikhailSorokin Jul 27, 2020
a3e5a11
Merging with query user info bug I fixed.
MikhailSorokin Jul 27, 2020
052a6fd
Updating some stuff to do if we are already cached + some refactooring.
MikhailSorokin Jul 27, 2020
a8b3e76
Cleaned up - ready for review.
Aug 3, 2020
bc20e5a
Cleanup of friend and presence classes.
Aug 3, 2020
4a28947
Added check upon testing - account portal seems to query the local us…
Aug 3, 2020
13a0060
Removal of lobby and party classes - they weren't meant to be put in …
Aug 3, 2020
0a2bc1b
Addressed both requested changes from Ruhrpottpatriot 8/3/2020.
Aug 4, 2020
428096c
Addressing style and some format fixes 8/3/20 from Ruhrpottpatriot.
Aug 4, 2020
ac92ec0
Updating with Bug/UserInfo query branch.
Aug 4, 2020
098c410
Final changes after testing.
Aug 4, 2020
cb2c92a
Final tests were conducted on a friends list of 6 people and now work…
MikhailSorokin Aug 24, 2020
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,22 @@

**Breaking changes:**

- Remove ability to create an FUniqueNetIdEpic from string [\#34](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/34)
- Add support for connect login and support for external account creation [\#29](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/pull/29) ([Ruhrpottpatriot](https://github.com/Ruhrpottpatriot))
- Make address of DevAuthTool customizable [\#24](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/pull/24) ([Ruhrpottpatriot](https://github.com/Ruhrpottpatriot))

**Implemented enhancements:**

- Change FUniqueNetIdEpic::GetHash [\#36](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/36)
- Allow an FUniqueNetIdEpic to be created from an Epic Account ID [\#33](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/33)
- DevAuthTool should have the address customizable [\#23](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/23)

**Fixed bugs:**

- Session Ids are still created as FUniqueNetIdEpic [\#35](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/35)
- FOnlineSessionEpic::FindSessions doesn't correctly cast from FUniqueNetId to FUniqueNetIdEpic [\#26](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/26)
- OnlineSubsystemEpic tries to initialize missing devToolPort field [\#25](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/issues/25)

## [v0.3_Presence](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/tree/v0.3_Presence) (2020-07-02)

[Full Changelog](https://github.com/Ruhrpottpatriot/OnlineSubsystemEpic/compare/v0.2_Sessions...v0.3_Presence)
Expand Down
1 change: 1 addition & 0 deletions KnownLimitations.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,3 +7,4 @@
* OnlineUser::GetUserInfo() retrieves the preferred nickname for the requested user properly, but the underlying user type doesn't store it just yet.
* Using the Identity interface with connect and the user account doesn't exist, the login will fail completely as there's currently no possibility to use continuance tokens in OSS.
* The asynchronous login blueprint node doesn't support the changed identity interface. A fix is planned for version 0.3.
* Friends interface AcceptInvite/RejectInvite/SendInvite has functions made in the FriendsInterface, but the SDK does not support them yet. - Mike
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
#include "OnlineSubsystemUtils.h"
#include "OnlineSubsystemEpicTypes.h"
#include "Utilities.h"
#include "Private/Utilities.h"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check if you and your team have configured the build process correctly. You shouldn't need the Private part of the include path.



IOnlineIdentityPtr UEpicOnlineServicesIdentityTask::GetIdentityInterface()
Expand Down
Loading